add error handling for when there is nothing#33
Merged
hensur merged 1 commit intomittwald:masterfrom Aug 21, 2025
Merged
Conversation
nofeldt
force-pushed
the
add-error-handling
branch
2 times, most recently
from
2604add to
9675d7e
Compare
hensur
reviewed
Aug 19, 2025
| if errors.As(err, &resErr) { | ||
| if resErr.StatusCode == http.StatusNotFound { | ||
| if strings.Contains(err.Error(), "request failed") { | ||
| return nil |
Member
There was a problem hiding this comment.
We should never map an error which results in a nil data return to nil. This would suggest to the user that the request has succeeded, while we return an empty response.
We should use a custom error type which suggest that this is a NotFound error (or an issuer not found error in the latter case)
Line 6 in acaae8f
nofeldt
force-pushed
the
add-error-handling
branch
from
9675d7e to
e56ce30
Compare
hensur
reviewed
Aug 19, 2025
| return nil | ||
| } | ||
|
|
||
| func (k *KVv1) mapError(err error) error { |
Member
There was a problem hiding this comment.
On second thought (I just noticed this affects the KV Engine), why would we need to map a StatusNotFound error to anything else? Besides breaking the existing API, mapping to a completely unrelated error doesn't seem useful. I think this should be kept as is, any consumer can check the StatusCode already?
nofeldt
force-pushed
the
add-error-handling
branch
from
e56ce30 to
1bb9ce7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when vault trys to access an element that is not availabe yet, vault returns an error. vault should return nil because no element is found.