Skip to content

add error handling for when there is nothing #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hensur merged 1 commit into from
Aug 21, 2025
+22 −1
Merged

add error handling for when there is nothing #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ import "errors"

var (
ErrEncKeyNotFound = errors.New("encryption key not found")
ErrIssuerNotFound = errors.New("issuer not found")
)
22 changes: 21 additions & 1 deletion pki.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
package vault

import (
"errors"
"github.com/hashicorp/vault/api"
"net/http"
"strings"
)

type PKI struct {
Service
}
Expand Down Expand Up @@ -252,7 +259,7 @@ func (k *PKI) ReadIssuer(issuerName string) (*PKIReadIssuerResponse, error) {
}, response, nil,
)
if err != nil {
return nil, err
return nil, k.mapError(err)
}

return response, nil
Expand Down Expand Up @@ -287,3 +294,16 @@ func (k *PKI) RevokeIssuer(issuerName string) (*PKIRevokeIssuerResponse, error)

return response, nil
}

func (k *PKI) mapError(err error) error {
resErr := &api.ResponseError{}
if errors.As(err, &resErr) {
if resErr.StatusCode == http.StatusInternalServerError {
if strings.Contains(err.Error(), "unable to find PKI issuer for reference") {
return ErrIssuerNotFound
}
}
}

return err
}
Loading