implement java.sql.ResultSet #30

NathanQingyangXu · 2025-01-29T01:28:03Z

https://jira.mongodb.org/browse/HIBERNATE-21

A subtask for "load by id" parent ticket (https://jira.mongodb.org/browse/HIBERNATE-20). Compared to DML processing (insertion, updating and deletion), aggregate query brings about more complexity by returning ResultSet. Given we just finished Statement and PreparedStatement, it seems good timing to proceed to the last important JDBC component implementation.

…' into HIBERNATE-21-implement-resultSet

…g insertion and in $project list

src/main/java/com/mongodb/hibernate/jdbc/MongoConnection.java

# Conflicts: # src/main/java/com/mongodb/hibernate/jdbc/MongoConnection.java # src/main/java/com/mongodb/hibernate/jdbc/MongoPreparedStatement.java # src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java

src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoStatementIntegrationTests.java

src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoPreparedStatementIntegrationTests.java

src/test/java/com/mongodb/hibernate/jdbc/MongoResultSetTests.java

…redStatementIntegrationTests.java Co-authored-by: Maxim Katcharov <[email protected]>

…mentIntegrationTests.java Co-authored-by: Maxim Katcharov <[email protected]>

…s.next()` after metadata checking

…SupportTests

Co-authored-by: Valentin Kovalenko <[email protected]>

…butor

… in $project stage

stIncMale

The last reviewed commit is 7b53c42.

I finally got to reviewing the test code.

src/test/java/com/mongodb/hibernate/jdbc/MongoConnectionTests.java

src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoStatementIntegrationTests.java

src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoPreparedStatementIntegrationTests.java

src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoStatementIntegrationTests.java

…java Co-authored-by: Valentin Kovalenko <[email protected]>

src/test/java/com/mongodb/hibernate/jdbc/MongoStatementTests.java

src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoPreparedStatementIntegrationTests.java

Co-authored-by: Valentin Kovalenko <[email protected]>

…' into HIBERNATE-21-implement-resultSet

NathanQingyangXu · 2025-03-14T01:48:49Z

The last reviewed commit is 7b53c42.

I finally got to reviewing the test code.

The jdbc integration testing classes are pretty messy for I hesitated to switch to hibernate-testing (which would simply a lot) for it is way higher level and might hide some low-level issue.

Thanks for your review comments. I appreciate it.

stIncMale

The last reviewed commit is 3bd9b5b.

MongoResultSetTests.java, MongoPreparedStatementTests.java are yet to be reviewed.

stIncMale

The last reviewed commit is 3bd9b5b. All files were reviewed.

src/test/java/com/mongodb/hibernate/jdbc/MongoPreparedStatementTests.java

src/test/java/com/mongodb/hibernate/jdbc/MongoResultSetTests.java

…view comments

stIncMale

The last reviewed commit is 323a09e.

@NathanQingyangXu,

Do you plan to do any more changes as per what you said in implement java.sql.ResultSet #30 (comment)?
implement java.sql.ResultSet #30 (comment) is still open and needs addressing.

NathanQingyangXu · 2025-03-14T16:08:32Z

The last reviewed commit is 323a09e.

@NathanQingyangXu,

Do you plan to do any more changes as per what you said in implement java.sql.ResultSet #30 (comment)?

implement java.sql.ResultSet #30 (comment) is still open and needs addressing.

I missed that. Adopted and pushed.

stIncMale · 2025-03-14T16:16:48Z

I missed that. Adopted and pushed.

What about the other thread?

NathanQingyangXu · 2025-03-14T16:23:02Z

I missed that. Adopted and pushed.

What about the other thread?

I missed that as well. Now both threads are resolved.

stIncMale

The last reviewed commit is 2daab80.

katcharov

LGTM

NathanQingyangXu requested review from jyemin and stIncMale January 29, 2025 01:28

implement java.sql.ResultSet

7c20f05

NathanQingyangXu force-pushed the HIBERNATE-21-implement-resultSet branch from c6a4aa5 to 7c20f05 Compare January 29, 2025 01:35

NathanQingyangXu and others added 3 commits January 29, 2025 09:41

use the new TODO tag

20f375d

Merge branch 'main' into HIBERNATE-21-implement-resultSet

b899e85

finish implementing MongoConnection#prepareStatement(String,int,int)

a40105a

jyemin requested review from katcharov and removed request for jyemin February 4, 2025 16:28

NathanQingyangXu and others added 8 commits February 5, 2025 13:04

Merge branch 'main' into HIBERNATE-21-implement-resultSet

12beda0

sync up with latest main branch

e3f881f

Merge remote-tracking branch 'origin/HIBERNATE-21-implement-resultSet…

a16b701

…' into HIBERNATE-21-implement-resultSet

Merge branch 'main' into HIBERNATE-21-implement-resultSet

cd5bdba

enrich testing cases

08fcabf

Merge remote-tracking branch 'origin/HIBERNATE-21-implement-resultSet…

c0208a3

…' into HIBERNATE-21-implement-resultSet

make testing more robust by making column ordered randomly both durin…

0da5436

…g insertion and in $project list

Merge branch 'main' into HIBERNATE-21-implement-resultSet

e9de245

NathanQingyangXu commented Feb 12, 2025

View reviewed changes

src/main/java/com/mongodb/hibernate/jdbc/MongoConnection.java Outdated Show resolved Hide resolved

NathanQingyangXu and others added 5 commits February 12, 2025 19:24

Merge branch 'main' into HIBERNATE-21-implement-resultSet

f76b4ba

make use of multi-line formatter to fix spotless issue

ddeb761

Merge branch 'main' into HIBERNATE-21-implement-resultSet

3cddf89

Merge branch 'main' into HIBERNATE-21-implement-resultSet

95d0738

# Conflicts: # src/main/java/com/mongodb/hibernate/jdbc/MongoConnection.java # src/main/java/com/mongodb/hibernate/jdbc/MongoPreparedStatement.java # src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java

resolve conflict with latest main branch

206673f

katcharov requested changes Feb 18, 2025

View reviewed changes

NathanQingyangXu and others added 6 commits February 19, 2025 08:40

Update src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoPrepa…

f4c8aa6

…redStatementIntegrationTests.java Co-authored-by: Maxim Katcharov <[email protected]>

add try block to ResultSet in MongoPreparedStatementIntegrationTests

a8f404d

Update src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoState…

9db8d59

…mentIntegrationTests.java Co-authored-by: Maxim Katcharov <[email protected]>

add try block to ResultSet in MongoStatementIntegrationTests; move `r…

19bf36a

…s.next()` after metadata checking

remove confusing exception message for MongoResultSet#getObject()

89f0224

simplify EXAMPLE_MQL to empty doc in MongoConnectionTests's ResultSet…

7edcf71

…SupportTests

NathanQingyangXu and others added 4 commits March 13, 2025 09:29

Update src/main/java/com/mongodb/hibernate/jdbc/MongoResultSet.java

1beded0

Co-authored-by: Valentin Kovalenko <[email protected]>

improve fields emptiness checking in MongoResultSet

8338768

add @DynamicInsert forbidding logic in MongoAdditionalMappingContri…

4a3840e

…butor

add logic to add _id unless suppressed or included explicitly already…

64eb6b7

… in $project stage

NathanQingyangXu force-pushed the HIBERNATE-21-implement-resultSet branch from 6ecc035 to 64eb6b7 Compare March 13, 2025 17:17

NathanQingyangXu requested a review from stIncMale March 13, 2025 21:07

stIncMale requested changes Mar 13, 2025

View reviewed changes

Update src/test/java/com/mongodb/hibernate/jdbc/MongoConnectionTests.…

7b53c42

…java Co-authored-by: Valentin Kovalenko <[email protected]>

stIncMale reviewed Mar 14, 2025

View reviewed changes

src/test/java/com/mongodb/hibernate/jdbc/MongoStatementTests.java Outdated Show resolved Hide resolved

stIncMale requested changes Mar 14, 2025

View reviewed changes

src/test/java/com/mongodb/hibernate/jdbc/MongoStatementTests.java Outdated Show resolved Hide resolved

src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoPreparedStatementIntegrationTests.java Show resolved Hide resolved

NathanQingyangXu and others added 4 commits March 13, 2025 21:42

Update src/test/java/com/mongodb/hibernate/jdbc/MongoStatementTests.java

1f979df

Co-authored-by: Valentin Kovalenko <[email protected]>

Update src/test/java/com/mongodb/hibernate/jdbc/MongoStatementTests.java

7ce1723

Co-authored-by: Valentin Kovalenko <[email protected]>

made changes as per code review comments

48711ce

Merge remote-tracking branch 'origin/HIBERNATE-21-implement-resultSet…

7ad1c50

…' into HIBERNATE-21-implement-resultSet

NathanQingyangXu added 2 commits March 13, 2025 21:49

fix a compiling error

b21b3a4

fix a spotless issue

3bd9b5b

stIncMale reviewed Mar 14, 2025

View reviewed changes

stIncMale requested changes Mar 14, 2025

View reviewed changes

further improvements to some jdbc unit testing classes as per code re…

323a09e

…view comments

NathanQingyangXu requested a review from stIncMale March 14, 2025 13:24

stIncMale reviewed Mar 14, 2025

View reviewed changes

simplify MongoStatement#getFieldNamesFromProjectStage()

2daab80

stIncMale approved these changes Mar 14, 2025

View reviewed changes

katcharov approved these changes Mar 14, 2025

View reviewed changes

NathanQingyangXu merged commit 499e600 into mongodb:main Mar 14, 2025
6 checks passed

NathanQingyangXu deleted the HIBERNATE-21-implement-resultSet branch March 14, 2025 17:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implement java.sql.ResultSet #30

implement java.sql.ResultSet #30

NathanQingyangXu commented Jan 29, 2025

stIncMale left a comment •

edited

Loading

NathanQingyangXu commented Mar 14, 2025

stIncMale left a comment

stIncMale left a comment

stIncMale left a comment •

edited

Loading

NathanQingyangXu commented Mar 14, 2025

stIncMale commented Mar 14, 2025

NathanQingyangXu commented Mar 14, 2025

stIncMale left a comment

katcharov left a comment

implement java.sql.ResultSet #30

implement java.sql.ResultSet #30

Conversation

NathanQingyangXu commented Jan 29, 2025

stIncMale left a comment • edited Loading

Choose a reason for hiding this comment

NathanQingyangXu commented Mar 14, 2025

stIncMale left a comment

Choose a reason for hiding this comment

stIncMale left a comment

Choose a reason for hiding this comment

stIncMale left a comment • edited Loading

Choose a reason for hiding this comment

NathanQingyangXu commented Mar 14, 2025

stIncMale commented Mar 14, 2025

NathanQingyangXu commented Mar 14, 2025

stIncMale left a comment

Choose a reason for hiding this comment

katcharov left a comment

Choose a reason for hiding this comment

stIncMale left a comment •

edited

Loading

stIncMale left a comment •

edited

Loading