Code

implement java.sql.ResultSet#30

Code

Merged

NathanQingyangXu merged 109 commits intomongodb:mainmongodb/mongo-hibernate:mainfrom NathanQingyangXu:HIBERNATE-21-implement-resultSetNathanQingyangXu/mongo-hibernate:HIBERNATE-21-implement-resultSetCopy head branch name to clipboardMar 14, 2025

Commits

Commits on Jan 29, 2025

• implement java.sql.ResultSet

  NathanQingyangXu

  committed
  7c20f05

  Copy full SHA for 7c20f05

• use the new TODO tag

  NathanQingyangXu

  committed
  20f375d

  Copy full SHA for 20f375d

• Merge branch 'main' into HIBERNATE-21-implement-resultSet

  NathanQingyangXu

  authored
  b899e85

  Copy full SHA for b899e85

Commits on Jan 31, 2025

• finish implementing MongoConnection#prepareStatement(String,int,int)

  NathanQingyangXu

  committed
  a40105a

  Copy full SHA for a40105a

Commits on Feb 5, 2025

• Merge branch 'main' into HIBERNATE-21-implement-resultSet

  NathanQingyangXu

  authored
  12beda0

  Copy full SHA for 12beda0

• sync up with latest main branch

  NathanQingyangXu

  committed
  e3f881f

  Copy full SHA for e3f881f

• Merge remote-tracking branch 'origin/HIBERNATE-21-implement-resultSet' into HIBERNATE-21-implement-resultSet

  NathanQingyangXu

  committed
  a16b701

  Copy full SHA for a16b701

Commits on Feb 11, 2025

• Merge branch 'main' into HIBERNATE-21-implement-resultSet

  NathanQingyangXu

  authored
  cd5bdba

  Copy full SHA for cd5bdba

Commits on Feb 12, 2025

• enrich testing cases

  NathanQingyangXu

  committed
  08fcabf

  Copy full SHA for 08fcabf

• Merge remote-tracking branch 'origin/HIBERNATE-21-implement-resultSet' into HIBERNATE-21-implement-resultSet

  NathanQingyangXu

  committed
  c0208a3

  Copy full SHA for c0208a3

• make testing more robust by making column ordered randomly both during insertion and in $project list

  NathanQingyangXu

  committed
  0da5436

  Copy full SHA for 0da5436

• Merge branch 'main' into HIBERNATE-21-implement-resultSet

  NathanQingyangXu

  authored
  e9de245

  Copy full SHA for e9de245

Commits on Feb 13, 2025

• Merge branch 'main' into HIBERNATE-21-implement-resultSet

  NathanQingyangXu

  authored
  f76b4ba

  Copy full SHA for f76b4ba

• make use of multi-line formatter to fix spotless issue

  NathanQingyangXu

  committed
  ddeb761

  Copy full SHA for ddeb761

Commits on Feb 14, 2025

• Merge branch 'main' into HIBERNATE-21-implement-resultSet

  NathanQingyangXu

  authored
  3cddf89

  Copy full SHA for 3cddf89

Commits on Feb 15, 2025

• Merge branch 'main' into HIBERNATE-21-implement-resultSet

  Show description for 95d0738
  NathanQingyangXu

  committed
  95d0738

  Copy full SHA for 95d0738

• resolve conflict with latest main branch

  NathanQingyangXu

  committed
  206673f

  Copy full SHA for 206673f

Commits on Feb 19, 2025

• Update src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoPreparedStatementIntegrationTests.java

  Show description for f4c8aa6
  

  NathanQingyangXu

  and

  katcharov

  authored
  f4c8aa6

  Copy full SHA for f4c8aa6

• add try block to ResultSet in MongoPreparedStatementIntegrationTests

  NathanQingyangXu

  committed
  a8f404d

  Copy full SHA for a8f404d

• Update src/integrationTest/java/com/mongodb/hibernate/jdbc/MongoStatementIntegrationTests.java

  Show description for 9db8d59
  

  NathanQingyangXu

  and

  katcharov

  authored
  9db8d59

  Copy full SHA for 9db8d59

• add try block to ResultSet in MongoStatementIntegrationTests; move rs.next() after metadata checking

  NathanQingyangXu

  committed
  19bf36a

  Copy full SHA for 19bf36a

• remove confusing exception message for MongoResultSet#getObject()

  NathanQingyangXu

  committed
  89f0224

  Copy full SHA for 89f0224

• simplify EXAMPLE_MQL to empty doc in MongoConnectionTests's ResultSetSupportTests

  NathanQingyangXu

  committed
  7edcf71

  Copy full SHA for 7edcf71

• remove confusing when&&then without given in MongoResultSetTests

  NathanQingyangXu

  committed
  01f7b28

  Copy full SHA for 01f7b28

• Merge branch 'main' into HIBERNATE-21-implement-resultSet

  NathanQingyangXu

  authored
  ee4753d

  Copy full SHA for ee4753d

Commits on Feb 20, 2025

• decrease duplication in MongoResultSetTests's method sources

  NathanQingyangXu

  committed
  ce039be

  Copy full SHA for ce039be

• Merge remote-tracking branch 'origin/HIBERNATE-21-implement-resultSet' into HIBERNATE-21-implement-resultSet

  NathanQingyangXu

  committed
  6605190

  Copy full SHA for 6605190

• add exhaustive getXXX() unit testing logic

  NathanQingyangXu

  committed
  d1497a3

  Copy full SHA for d1497a3

• remove unnecessary usage of @Nested in integration testing cases

  NathanQingyangXu

  committed
  b745d0d

  Copy full SHA for b745d0d

• add round-trip testing case to combine PreparedStatement and ResultSet together

  NathanQingyangXu

  committed
  f52b570

  Copy full SHA for f52b570

• change column index checking exception message

  NathanQingyangXu

  committed
  2f58a9e

  Copy full SHA for 2f58a9e

• change SQLException message in MongoStatement#executeQueryCommand()

  NathanQingyangXu

  committed
  df032c9

  Copy full SHA for df032c9

• rename testing case in MongoResultSetTests to testIsIdempotent()

  NathanQingyangXu

  committed
  205835c

  Copy full SHA for 205835c

Commits on Feb 21, 2025

• clean up adapter classes; add logic and testing case to close ResultSet when the originating Statement is closed

  NathanQingyangXu

  committed
  dbfb4d2

  Copy full SHA for dbfb4d2

• improve implementation of MongoStatement#executeQueryCommmand by removing the usage of stream

  NathanQingyangXu

  committed
  7b35d61

  Copy full SHA for 7b35d61

• rename CloseTests to ClosedTests and move the close statement as first statement in each testing cases

  NathanQingyangXu

  committed
  d2d16e5

  Copy full SHA for d2d16e5

• Merge branch 'main' into HIBERNATE-21-implement-resultSet

  NathanQingyangXu

  authored
  b8053b6

  Copy full SHA for b8053b6

Commits on Feb 24, 2025

• revert back changes to ResultSetAdapter to avoid touching it again and again in the future

  NathanQingyangXu

  committed
  7a76e79

  Copy full SHA for 7a76e79

Commits on Feb 25, 2025

• Merge branch 'main' into HIBERNATE-21-implement-resultSet

  Show description for 3de532a
  NathanQingyangXu

  committed
  3de532a

  Copy full SHA for 3de532a

• fix conflict with latest main branch

  NathanQingyangXu

  committed
  4e7074e

  Copy full SHA for 4e7074e

Commits on Feb 26, 2025

• Merge branch 'main' into HIBERNATE-21-implement-resultSet

  NathanQingyangXu

  authored
  8706876

  Copy full SHA for 8706876

• Update src/test/java/com/mongodb/hibernate/jdbc/MongoResultSetTests.java

  Show description for 077c5b8
  

  NathanQingyangXu

  and

  katcharov

  authored
  077c5b8

  Copy full SHA for 077c5b8

• update based on some code review comments

  NathanQingyangXu

  committed
  1d1a4c4

  Copy full SHA for 1d1a4c4

• Merge remote-tracking branch 'origin/HIBERNATE-21-implement-resultSet' into HIBERNATE-21-implement-resultSet

  NathanQingyangXu

  committed
  8e05feb

  Copy full SHA for 8e05feb

• rename some methods in MongoResultSetTests

  NathanQingyangXu

  committed
  7d41973

  Copy full SHA for 7d41973

Commits on Feb 27, 2025

• refactor the MongoResultSetTests#testGetValues() based on @MethodSource

  NathanQingyangXu

  committed
  858fc81

  Copy full SHA for 858fc81

• add validation of "false" BsonBoolean in MongoResultSetTests#testGetValues

  NathanQingyangXu

  committed
  d67c0ad

  Copy full SHA for d67c0ad

• Merge branch 'main' into HIBERNATE-21-implement-resultSet

  Show description for cb189c2
  NathanQingyangXu

  committed
  cb189c2

  Copy full SHA for cb189c2

• merge in latest main

  NathanQingyangXu

  committed
  2da14ed

  Copy full SHA for 2da14ed

• Merge branch 'main' into HIBERNATE-21-implement-resultSet

  Show description for c46f1cf
  NathanQingyangXu

  committed
  c46f1cf

  Copy full SHA for c46f1cf

• refactor getters testing avoiding the usage of MethodSource

  NathanQingyangXu

  committed
  4351449

  Copy full SHA for 4351449

• change testing method name from getOpenPreconditionInvocations

  NathanQingyangXu

  committed
  5b11a8b

  Copy full SHA for 5b11a8b

Commits on Feb 28, 2025

• improve MongoResultSetTests

  NathanQingyangXu

  committed
  54b562f

  Copy full SHA for 54b562f

• Merge remote-tracking branch 'origin/HIBERNATE-21-implement-resultSet' into HIBERNATE-21-implement-resultSet

  Show description for 936c70a
  NathanQingyangXu

  committed
  936c70a

  Copy full SHA for 936c70a

• add Getter testing cases into MongoResultSetTests

  NathanQingyangXu

  committed
  d084f15

  Copy full SHA for d084f15

Commits on Mar 3, 2025

• switch to testing mode in Java driver

  NathanQingyangXu

  committed
  88c6ffd

  Copy full SHA for 88c6ffd

• drop support of the "byte", "short" and "float" sql types for both MongoPreparedStatement and MongoResultSet

  NathanQingyangXu

  committed
  c4b0c0b

  Copy full SHA for c4b0c0b

• refactor MongoStatementIntegrationTests and MongoPreparedStatementIntegrationTests to remove code duplication

  NathanQingyangXu

  committed
  f48a8ce

  Copy full SHA for f48a8ce

Commits on Mar 4, 2025

• refactor JDBC closed and range checking testing code to align with MongoResultSetTests

  NathanQingyangXu

  committed
  8dc4510

  Copy full SHA for 8dc4510

• remove TODO-HIBERNATE-21 comments from MongoStatement

  NathanQingyangXu

  committed
  2a1b128

  Copy full SHA for 2a1b128

• add ticket references to setQueryTimeout() and setFetchSize() implementation; remove unused methods after Hibernate codebase walkthrough

  NathanQingyangXu

  committed
  2a4e40a

  Copy full SHA for 2a4e40a

• Merge branch 'main' into HIBERNATE-21-implement-resultSet

  Show description for e02eaf2
  NathanQingyangXu

  committed
  e02eaf2

  Copy full SHA for e02eaf2

• resolve conflict with latest main

  NathanQingyangXu

  committed
  3793564

  Copy full SHA for 3793564

• implemented MongoStatement#getMaxRows() and MongoStatement#setMaxRows(int) methods

  NathanQingyangXu

  committed
  a603b25

  Copy full SHA for a603b25

• add logic to use maxRows in MongoStatement#executeQueryCommand() and testing cases

  NathanQingyangXu

  committed
  a393025

  Copy full SHA for a393025

Commits on Mar 6, 2025

• addesses two code review comments by Maxim

  NathanQingyangXu

  committed
  0a16575

  Copy full SHA for 0a16575

• Update src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java

  Show description for 9630209
  

  NathanQingyangXu

  and

  stIncMale

  authored
  9630209

  Copy full SHA for 9630209

• improve MongoExtension by creating MongoClient only once for top class (not @Nested classes)

  NathanQingyangXu

  committed
  fd063a5

  Copy full SHA for fd063a5

• add parameter setting checking in MongoPreparedStatement#executeQuery() and MongoPreparedStatement#executeUpdate

  NathanQingyangXu

  committed
  c2bafa6

  Copy full SHA for c2bafa6

• add logic to throw SQLException from PreparedStatement for the 4 Statement methods which accept SQL

  NathanQingyangXu

  committed
  8cc2924

  Copy full SHA for 8cc2924

• add logic to ensure last open ResultSet is closed when Statement invokes query methods returning ResultSet

  NathanQingyangXu

  committed
  0cc9784

  Copy full SHA for 0cc9784

• improve coding in MongoStatement#executeQueryCommand()

  NathanQingyangXu

  committed
  221ba0b

  Copy full SHA for 221ba0b

• move startTransactionIfNeeded into try block to catch potential RuntimeException

  NathanQingyangXu

  committed
  df31b39

  Copy full SHA for df31b39

• rename MongoStatement#getFieldNamesFromProjectDocument to #getFieldNamesFromProjectStage; removed javadoc

  NathanQingyangXu

  committed
  0ab4e33

  Copy full SHA for 0ab4e33

• remove MongoStatement#setMaxRows() implementation for it is not used in Hibernate for our dialect

  NathanQingyangXu

  committed
  496192e

  Copy full SHA for 496192e

Commits on Mar 7, 2025

• remove javadocs from adapter classes; add missing adapter methods in ResultSetMetaDataAdapter

  NathanQingyangXu

  committed
  cddac5c

  Copy full SHA for cddac5c

• remove ResultSetMetadata stuff and leave ticket references to select native query tickets

  NathanQingyangXu

  committed
  b431e29

  Copy full SHA for b431e29

• Update src/main/java/com/mongodb/hibernate/jdbc/MongoResultSet.java

  Show description for 9bb639b
  

  NathanQingyangXu

  and

  stIncMale

  authored
  9bb639b

  Copy full SHA for 9bb639b

• make range checking logic consistent between MongoResultSet and MongoPreparedStatement

  NathanQingyangXu

  committed
  b2f0dea

  Copy full SHA for b2f0dea

• make MongoResultSet checkClosed() method consistent with MongoStatement's

  NathanQingyangXu

  committed
  79b79f3

  Copy full SHA for 79b79f3

• throw exception for MongoResultSet#findColumn until we work on native query

  NathanQingyangXu

  committed
  a3dfdeb

  Copy full SHA for a3dfdeb

• improve MongoResultSet#close warning message

  NathanQingyangXu

  committed
  f0524d0

  Copy full SHA for f0524d0

• rename Function parameter name in MongoResultSet#getValue()

  NathanQingyangXu

  committed
  afd52f4

  Copy full SHA for afd52f4

• add missing MongoResultSet#getBytes() implementation

  NathanQingyangXu

  committed
  9a4778b

  Copy full SHA for 9a4778b

• simplify the implementation of MongoResultSet#wasNull

  NathanQingyangXu

  committed
  25db0e1

  Copy full SHA for 25db0e1

• clean up jdbc classes

  NathanQingyangXu

  committed
  221aba5

  Copy full SHA for 221aba5

Commits on Mar 11, 2025

• Merge branch 'main' into HIBERNATE-21-implement-resultSet

  NathanQingyangXu

  committed
  cec455b

  Copy full SHA for cec455b

Commits on Mar 12, 2025

• Merge branch 'main' into HIBERNATE-21-implement-resultSet

  Show description for 02ab460
  NathanQingyangXu

  committed
  02ab460

  Copy full SHA for 02ab460

• merge in latest main branch

  NathanQingyangXu

  committed
  2693594

  Copy full SHA for 2693594

• code refactor to combine setter and used state into one class in MongoPreparedStatement

  NathanQingyangXu

  committed
  5fa9c56

  Copy full SHA for 5fa9c56

• improve the error handling of the 4 forbidden methods accepting SQL in MongoPreparedStatement

  NathanQingyangXu

  committed
  dc816a5

  Copy full SHA for dc816a5

• add closing last open ResultSet for all execution methods of MongoStatement and MongoPreparedStatement

  NathanQingyangXu

  committed
  26c0951

  Copy full SHA for 26c0951

• move lastReadColumnValueWasNull assignment statement after toJavaConverter is applied

  NathanQingyangXu

  committed
  e8f97d5

  Copy full SHA for e8f97d5

• change logic to thrown exception if some field is missing

  NathanQingyangXu

  committed
  b223c10

  Copy full SHA for b223c10

Commits on Mar 13, 2025

• change as per review comments

  NathanQingyangXu

  committed
  c796b29

  Copy full SHA for c796b29

• add unit testing cases to ensure last open resultSet is closed when executeXXX methods are invoked in both MongoPreparedStatement and MongoStatement

  NathanQingyangXu

  committed
  850259c

  Copy full SHA for 850259c

• Update src/main/java/com/mongodb/hibernate/jdbc/MongoResultSet.java

  Show description for 1beded0
  

  NathanQingyangXu

  and

  stIncMale

  authored
  1beded0

  Copy full SHA for 1beded0

• improve fields emptiness checking in MongoResultSet

  NathanQingyangXu

  committed
  8338768

  Copy full SHA for 8338768

• add @DynamicInsert forbidding logic in MongoAdditionalMappingContributor

  NathanQingyangXu

  committed
  4a3840e

  Copy full SHA for 4a3840e

• add logic to add _id unless suppressed or included explicitly already in $project stage

  NathanQingyangXu

  committed
  64eb6b7

  Copy full SHA for 64eb6b7

Commits on Mar 14, 2025

• Update src/test/java/com/mongodb/hibernate/jdbc/MongoConnectionTests.java

  Show description for 7b53c42
  

  NathanQingyangXu

  and

  stIncMale

  authored
  7b53c42

  Copy full SHA for 7b53c42

• Update src/test/java/com/mongodb/hibernate/jdbc/MongoStatementTests.java

  Show description for 1f979df
  

  NathanQingyangXu

  and

  stIncMale

  authored
  1f979df

  Copy full SHA for 1f979df

• Update src/test/java/com/mongodb/hibernate/jdbc/MongoStatementTests.java

  Show description for 7ce1723
  

  NathanQingyangXu

  and

  stIncMale

  authored
  7ce1723

  Copy full SHA for 7ce1723

• made changes as per code review comments

  NathanQingyangXu

  committed
  48711ce

  Copy full SHA for 48711ce

• Merge remote-tracking branch 'origin/HIBERNATE-21-implement-resultSet' into HIBERNATE-21-implement-resultSet

  NathanQingyangXu

  committed
  7ad1c50

  Copy full SHA for 7ad1c50

• fix a compiling error

  NathanQingyangXu

  committed
  b21b3a4

  Copy full SHA for b21b3a4

• fix a spotless issue

  NathanQingyangXu

  committed
  3bd9b5b

  Copy full SHA for 3bd9b5b

• further improvements to some jdbc unit testing classes as per code review comments

  NathanQingyangXu

  committed
  323a09e

  Copy full SHA for 323a09e

• simplify MongoStatement#getFieldNamesFromProjectStage()

  NathanQingyangXu

  committed
  2daab80

  Copy full SHA for 2daab80