CLOUDP-319781: Added http RoundTripper that logs payload diffs for Atlas API endpoints #2525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-karpukhin
added
the
cloud-tests
igor-karpukhin
had a problem deploying
to
openshift-test
GitHub Actions
Error
josvazg
reviewed
Jul 17, 2025
|
|
||
| func (t *TransportWithDiff) RoundTrip(req *http.Request) (*http.Response, error) { | ||
| if req.Method == http.MethodPut || req.Method == http.MethodPatch { | ||
| diffString, err := t.tryCalculateDiff(req, |
There was a problem hiding this comment.
:nit: why try...?
Suggested change
| diffString, err := t.tryCalculateDiff(req, | |
| diffString, err := t.calculateDiff(req, |
josvazg
reviewed
Jul 17, 2025
| } | ||
|
|
||
| func (t *TransportWithDiff) tryCalculateDiff(req *http.Request, cleanupFuncs ...cleanupFunc) (string, error) { | ||
| var bodyCopy []byte |
There was a problem hiding this comment.
nit: would have split this into further functions, but ok.
josvazg
approved these changes
Jul 17, 2025
igor-karpukhin
temporarily deployed
to
openshift-test
GitHub Actions
Inactive
s-urbaniak
approved these changes
Jul 21, 2025
This was referenced Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added http RoundTripper that logs payload diffs for Atlas API endpoints
Checklist