fix(money): reject fractional-cent numbers - #54
Merged
ralyodio merged 1 commit intoJul 30, 2026
Conversation
ralyodio
pushed a commit
that referenced
this pull request
Jul 31, 2026
The numeric path in setupAmountUsd silently rounded values like 1.234 to 1.23. The string path already enforces cent-precision via regex; make the numeric path reject fractional cents too so both inputs follow the same rule. Fixes #54 Co-authored-by: qwenbona <qwenbona@users.noreply.github.com>
ralyodio
added a commit
that referenced
this pull request
Jul 31, 2026
PR #59 made the numeric path of setupAmountUsd reject values finer than a cent, but left the assertion that 2.345 rounds to 2.35 — the exact behavior it removed. That assertion has failed on master ever since, so every PR opened since #59 shows a red test check. Assert the numeric path on a value it actually accepts, and add the regression coverage issue #54 asked for (1.234 and 0.004) that #59 described but never landed. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1.234and0.004numeric inputsValidation
node --test tests\*.mjspassed 22 tests