fix(email): HTML-escape interpolated values in email templates - #57
Closed
qwenbona wants to merge 1 commit into
Closed
fix(email): HTML-escape interpolated values in email templates#57qwenbona wants to merge 1 commit into
qwenbona wants to merge 1 commit into
Conversation
Dynamic values (GitHub issue titles, actor names, repo names, tenant brands) were interpolated raw into HTML email bodies. A GitHub issue titled <script>alert(1)</script> would land unescaped in the repo owner's notification email. Add escapeHtml and apply it to every dynamic value rendered in HTML context. Fixes moshcoder#48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamic values (GitHub issue titles, actor names, repo names, tenant brands) were interpolated raw into HTML email bodies. A GitHub issue titled <script>alert(1)</script> lands unescaped in the repo owner notification email.
Add escapeHtml helper and apply to every dynamic value in HTML context.
Fixes #48