Skip to content

fix(email): HTML-escape interpolated values in email templates #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
qwenbona wants to merge 1 commit into from
Closed

fix(email): HTML-escape interpolated values in email templates #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions lib/email.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@

const RESEND_ENDPOINT = "https://api.resend.com/emails";

const escapeHtml = (s: string): string =>
s.replace(/&/g, "&amp;").replace(/</g, "&lt;").replace(/>/g, "&gt;").replace(/"/g, "&quot;");

export function isEmailConfigured(): boolean {
return Boolean(process.env.RESEND_API_KEY);
}
Expand Down Expand Up @@ -90,7 +93,7 @@ export function sendWaitlistVerification(opts: {
<tr><td align="center">
<table role="presentation" width="100%" style="max-width:480px;background:#141416;border:1px solid #26262a;border-radius:12px;padding:28px">
<tr><td>
<h1 style="margin:0 0 8px;font-size:22px;color:#9EF01A">${brand} 🤘</h1>
<h1 style="margin:0 0 8px;font-size:22px;color:#9EF01A">${escapeHtml(brand)} 🤘</h1>
<p style="margin:0 0 20px;line-height:1.5;color:#c9c9c9">
You're almost in. Confirm your email to lock in your spot in the pit.
</p>
Expand Down Expand Up @@ -135,10 +138,10 @@ export function sendGithubClosedNotification(opts: {
<tr><td align="center">
<table role="presentation" width="100%" style="max-width:480px;background:#141416;border:1px solid #26262a;border-radius:12px;padding:24px">
<tr><td>
<p style="margin:0 0 6px;font-size:12px;letter-spacing:.12em;text-transform:uppercase;color:#8a8a8a">${opts.repo}</p>
<p style="margin:0 0 6px;font-size:12px;letter-spacing:.12em;text-transform:uppercase;color:#8a8a8a">${escapeHtml(opts.repo)}</p>
<h1 style="margin:0 0 12px;font-size:18px;color:#9EF01A">${opts.kind} #${opts.number} ${verb} 🤘</h1>
<p style="margin:0 0 16px;line-height:1.5;color:#d6d6d6">${opts.title}</p>
<p style="margin:0 0 18px;font-size:13px;color:#9a9a9a">by ${opts.actor}</p>
<p style="margin:0 0 16px;line-height:1.5;color:#d6d6d6">${escapeHtml(opts.title)}</p>
<p style="margin:0 0 18px;font-size:13px;color:#9a9a9a">by ${escapeHtml(opts.actor)}</p>
<a href="${opts.url}" style="display:inline-block;background:#9EF01A;color:#0b0b0c;text-decoration:none;font-weight:700;padding:10px 18px;border-radius:8px">View on GitHub</a>
</td></tr>
</table>
Expand Down Expand Up @@ -167,7 +170,7 @@ export function sendPasswordReset(opts: {
<tr><td align="center">
<table role="presentation" width="100%" style="max-width:480px;background:#141416;border:1px solid #26262a;border-radius:12px;padding:28px">
<tr><td>
<h1 style="margin:0 0 8px;font-size:22px;color:#9EF01A">${brand} 🤘</h1>
<h1 style="margin:0 0 8px;font-size:22px;color:#9EF01A">${escapeHtml(brand)} 🤘</h1>
<p style="margin:0 0 20px;line-height:1.5;color:#c9c9c9">
Reset your password. This link expires in 1 hour.
</p>
Expand Down
Loading