Skip to content

[MOSIP-44324] Corrected ng2-pdf-viewer version#247

Merged
mayuradesh merged 1 commit intomosip:developfrom
GOKULRAJ136:pdf-dev
Jan 27, 2026
Merged

[MOSIP-44324] Corrected ng2-pdf-viewer version#247
mayuradesh merged 1 commit intomosip:developfrom
GOKULRAJ136:pdf-dev

Conversation

@GOKULRAJ136
Copy link
Contributor

@GOKULRAJ136 GOKULRAJ136 commented Jan 27, 2026

Summary by CodeRabbit

  • Chores
    • Updated the PDF viewer dependency to improve compatibility and stability in the pre-registration interface.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026

Walkthrough

A single dependency version update in the pre-registration-ui package configuration downgrades ng2-pdf-viewer from version 5.3.3 to 3.0.8 and removes the caret constraint, pinning the package to an exact version.

Changes

Cohort / File(s) Summary
Dependency Version Pinning
pre-registration-ui/package.json
Downgraded ng2-pdf-viewer from ^5.3.3 to 3.0.8 (pinned exact version)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A hop, a skip, to version 3,
The PDF viewer now locked and free!
No caret dance, just steady ground—
Where stable dependencies are found! 📄✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Corrected ng2-pdf-viewer version' accurately reflects the main change: downgrading and pinning the ng2-pdf-viewer dependency from ^5.3.3 to 3.0.8.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@pre-registration-ui/package.json`:
- Line 43: Replace the unsupported ng2-pdf-viewer version in package.json (the
"ng2-pdf-viewer" dependency) with a release that supports Angular 7 (for example
^7.0.0 or ^5.3.3), run your package manager to reinstall, verify the app builds
and PDF components render, and confirm the installed pdfjs-dist transitive
dependency is a patched version; adjust the chosen ng2-pdf-viewer version if any
peerDependency warnings arise with Angular 7.2.0.

@mayuradesh mayuradesh merged commit ea0f4f1 into mosip:develop Jan 27, 2026
8 checks passed
GOKULRAJ136 added a commit to GOKULRAJ136/pre-registration-ui that referenced this pull request Feb 3, 2026
GOKULRAJ136 added a commit to GOKULRAJ136/pre-registration-ui that referenced this pull request Feb 3, 2026
This reverts commit ea0f4f1.

Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
mayuradesh pushed a commit that referenced this pull request Feb 3, 2026
This reverts commit ea0f4f1.

Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants