[MOSIP-44324] Corrected ng2-pdf-viewer version#247
Merged
mayuradesh merged 1 commit intomosip:developfrom Jan 27, 2026
Merged
Conversation
Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
WalkthroughA single dependency version update in the pre-registration-ui package configuration downgrades ng2-pdf-viewer from version 5.3.3 to 3.0.8 and removes the caret constraint, pinning the package to an exact version. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@pre-registration-ui/package.json`:
- Line 43: Replace the unsupported ng2-pdf-viewer version in package.json (the
"ng2-pdf-viewer" dependency) with a release that supports Angular 7 (for example
^7.0.0 or ^5.3.3), run your package manager to reinstall, verify the app builds
and PDF components render, and confirm the installed pdfjs-dist transitive
dependency is a patched version; adjust the chosen ng2-pdf-viewer version if any
peerDependency warnings arise with Angular 7.2.0.
mayuradesh
approved these changes
Jan 27, 2026
GOKULRAJ136
added a commit
to GOKULRAJ136/pre-registration-ui
that referenced
this pull request
Feb 3, 2026
This reverts commit ea0f4f1.
GOKULRAJ136
added a commit
to GOKULRAJ136/pre-registration-ui
that referenced
this pull request
Feb 3, 2026
This reverts commit ea0f4f1. Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
mayuradesh
pushed a commit
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.