Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin setuptools version to 70.3.0 #823

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Pin setuptools version to 70.3.0 #823

merged 1 commit into from
Jul 24, 2024

Conversation

akkomar
Copy link
Contributor

@akkomar akkomar commented Jul 24, 2024

Recent releases of setuptools cause the build to fail. This fixes it and will unblock #822

Checklist for reviewer:

For glean changes:

  • Update templates/include/glean/CHANGELOG.md

For modifications to schemas in restricted namespaces (see CODEOWNERS):

@auto-assign auto-assign bot requested a review from scholtzan July 24, 2024 16:07
@scholtzan scholtzan merged commit 36abca4 into main Jul 24, 2024
2 checks passed
@akkomar akkomar deleted the setuptools_freeze branch July 24, 2024 16:29
@@ -69,7 +69,7 @@ COPY --from=mozilla/ingestion-sink:latest /app/ingestion-sink/target /app/target

# Install python dependencies
COPY requirements.txt requirements-dev.txt ./
RUN pip3 install --upgrade pip setuptools && \
RUN pip3 install --upgrade pip setuptools==70.3.0 && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the newer setuptools cause problems running things locally? If so, then I'd think you'd also want to pin setuptools in requirements.txt.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under normal circumstances I agree, but if the setuptools version incompatibility was going to consistently cause problems for devs that would take precedence IMO.

Luckily this is a moot point at the moment because it turns out the latest production versions of Python only come with setuptools 65 installed by default (and Python 3.8, which is the version used in the Dockerfile, comes with setuptools 56 by default).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants