Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin setuptools version to 70.3.0 #823

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Pin setuptools version to 70.3.0 #823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ COPY --from=mozilla/ingestion-sink:latest /app/ingestion-sink/target /app/target

# Install python dependencies
COPY requirements.txt requirements-dev.txt ./
RUN pip3 install --upgrade pip setuptools && \
RUN pip3 install --upgrade pip setuptools==70.3.0 && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the newer setuptools cause problems running things locally? If so, then I'd think you'd also want to pin setuptools in requirements.txt.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should add setuptools to requirements: https://github.com/mozilla-services/mozilla-pipeline-schemas/blob/36abca46ba9a311628ef8cde510e9f74becba16a/requirements-dev.txt#L28C3-L29

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under normal circumstances I agree, but if the setuptools version incompatibility was going to consistently cause problems for devs that would take precedence IMO.

Luckily this is a moot point at the moment because it turns out the latest production versions of Python only come with setuptools 65 installed by default (and Python 3.8, which is the version used in the Dockerfile, comes with setuptools 56 by default).

pip3 install -r requirements.txt -r requirements-dev.txt

# Install Java dependencies
Expand Down