Skip to content
This repository was archived by the owner on Jun 25, 2020. It is now read-only.

Avoiding horizontal scroll #474

Merged
merged 1 commit into from
Dec 4, 2017

Conversation

jessuircleydson
Copy link
Contributor

BEFORE
captura de tela 2017-12-04 as 12 05 07

AFTER
captura de tela 2017-12-04 as 12 07 46

@alanmoo alanmoo requested a review from ScottDowne December 4, 2017 17:41
@ScottDowne ScottDowne temporarily deployed to advocacy-mozilla-org-st-pr-474 December 4, 2017 17:46 Inactive
@alanmoo
Copy link
Contributor

alanmoo commented Dec 4, 2017

Hi, thanks for the contribution! Which url is that screenshot from?

@jessuircleydson
Copy link
Contributor Author

jessuircleydson commented Dec 4, 2017

You're welcome!
Where did i see that?
Apparently that error occur anywhere the footer was applied, so maybe every page haha.
I've saw here https://advocacy.mozilla.org/, so i reproduced the same in my local machine.
The reason is here /net-neutrality/footer.less

@ScottDowne
Copy link
Contributor

Thanks for finding and fixing this @jessuircleydson !

What happened is recently we added a new page advocacy.mozilla.org/net-neutrality with a slightly modified footer. It's leaking CSS into the rest of the page it seems.

It would be great too if we can fix the new footer so it doesn't leak again in the future. I've filed #478 to future proof this, if you're interested @jessuircleydson you're welcome to take a look.

@ScottDowne ScottDowne merged commit cf648d7 into mozilla:master Dec 4, 2017
@jessuircleydson
Copy link
Contributor Author

@ScottDowne yeah i can take a look

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants