Skip to content

WebGLUniforms: Assign compareFunction lazily to retain tree-shaking. #28670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2024
Merged

WebGLUniforms: Assign compareFunction lazily to retain tree-shaking. #28670

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f272019
WebGLUniforms: lazily create shadow texture for tree-shaking
CodyJasonBennett Jun 16, 2024
baadc2d
WebGLUniforms: lazily set compareFunction instead
CodyJasonBennett Jun 17, 2024
fbb27b6
Update WebGLUniforms.js
Mugen87 Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/renderers/webgl/WebGLUniforms.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@ import { LessEqualCompare } from '../../constants.js';

const emptyTexture = /*@__PURE__*/ new Texture();

const emptyShadowTexture = /*@__PURE__*/ new DepthTexture( 1, 1 );
emptyShadowTexture.compareFunction = LessEqualCompare;
let emptyShadowTexture = null;

const emptyArrayTexture = /*@__PURE__*/ new DataArrayTexture();
const empty3dTexture = /*@__PURE__*/ new Data3DTexture();
Expand Down Expand Up @@ -569,6 +568,13 @@ function setValueT1( gl, v, textures ) {

}

if ( this.type === gl.SAMPLER_2D_SHADOW && emptyShadowTexture === null ) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it also fix the tree shaking issue if we do the following?

let emptyTexture2D;

if ( this.type === gl.SAMPLER_2D_SHADOW ) {

    emptyShadowTexture.compareFunction = LessEqualCompare;
    emptyTexture2D = emptyShadowTexture;

} else {

    emptyTexture2D = emptyTexture;

}

I suspect tree-shaking breaks since the code accesses compareFunction right away. If we just move this bit to setValueT1(), we don't need an additional if check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, anything were we don't do a mutation in the top-level scope.


emptyShadowTexture = new DepthTexture( 1, 1 );
emptyShadowTexture.compareFunction = LessEqualCompare;

}

const emptyTexture2D = ( this.type === gl.SAMPLER_2D_SHADOW ) ? emptyShadowTexture : emptyTexture;

textures.setTexture2D( v || emptyTexture2D, unit );
Expand Down