Add "last trip stop"

[mmathieum]

• Add "last trip stop" commons-java#23

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the RouteDirectionStop data structure by adding a new property, alwaysLastTripStop. This addition allows for more precise identification of terminal stops within a route direction, which can be crucial for various transit-related functionalities. The changes ensure that this new piece of information is correctly handled across the application's data layer, including its representation in JSON, storage in the database, and retrieval via content providers, all while being controlled by a feature flag for flexible deployment.

Highlights

• New Data Field: Introduced a new alwaysLastTripStop Boolean field within the RouteDirectionStop data model to explicitly mark if a stop is always the last stop of a trip.
• Data Model Integration: Integrated the alwaysLastTripStop field into RouteDirectionStop constructors, JSON serialization/deserialization, and ContentValues conversion for persistent storage and retrieval.
• Database Contract and Providers Update: Updated GTFSProviderContract and related content providers (GTFSPOIProvider, GTFSProviderDbHelper, GTFSRDSProvider) to include the new alwaysLastTripStop column in database schemas and query projections, guarded by a feature flag.

Changelog

• src/main/java/org/mtransit/android/commons/data/RouteDirectionStop.java
  • Added a new alwaysLastTripStop field to the class.
  • Updated constructors to accept and initialize the new alwaysLastTripStop field.
  • Modified toJSON and fromJSONStatic methods to serialize and deserialize the alwaysLastTripStop field, protected by FeatureFlags.F_EXPORT_DIRECTION_STOP_LAST.
  • Updated toContentValues and fromCursorStatic methods to handle the new alwaysLastTripStop column in database operations.
  • Implemented a new getter method isAlwaysLastTripStop() to access the field's value.
• src/main/java/org/mtransit/android/commons/provider/GTFSProviderContract.java
  • Added a new static string constant T_DIRECTION_STOPS_K_ALWAYS_LAST_TRIP_STOP for the new database column.
  • Updated the makePROJECTION_ROUTE_DIRECTION_STOP method to conditionally include the new column in projections based on FeatureFlags.F_EXPORT_DIRECTION_STOP_LAST.
• src/main/java/org/mtransit/android/commons/provider/gtfs/GTFSPOIProvider.java
  • Updated the getNewProjectionMap method to conditionally include the new T_DIRECTION_STOPS_K_ALWAYS_LAST_TRIP_STOP column in the projection map, based on FeatureFlags.F_EXPORT_DIRECTION_STOP_LAST.
• src/main/java/org/mtransit/android/commons/provider/gtfs/GTFSProviderDbHelper.java
  • Added a new static string constant T_DIRECTION_STOPS_K_ALWAYS_LAST_TRIP_STOP to define the new database column name.
• src/main/java/org/mtransit/android/commons/provider/gtfs/GTFSRDSProvider.java
  • Updated the append methods to conditionally include the new T_DIRECTION_STOPS_K_ALWAYS_LAST_TRIP_STOP column in the projection builders, based on FeatureFlags.F_EXPORT_DIRECTION_STOP_LAST.

Activity

• No specific activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces an 'alwaysLastTripStop' property to RouteDirectionStop, controlled by a feature flag. The implementation is mostly correct, but I've identified a critical issue that could lead to a crash when the feature flag is disabled due to unsafe database cursor access. I've also provided a suggestion to improve the handling of nullable booleans for better code quality. Please review the specific comments for details.