No-code parser > trip head-sign clean > remove "Via" option

[mmathieum]

Requires:

• No-code > trip head-sign clean > remove "Via" option parser#7

[gemini-code-assist]

Summary of Changes

Hello @mmathieum, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the cleanTripHeadsign utility by introducing a new parameter that allows callers to optionally enable the removal of 'Via' prefixes from trip headsigns. This provides greater control over the string cleaning process for trip headsigns, making the 'Via' removal configurable rather than absent.

Highlights

• Function Signature Change: The cleanTripHeadsign function in src/main/java/org/mtransit/commons/StringsCleaner.kt now accepts an additional boolean parameter, removeVia, to control specific cleaning behavior.
• New Cleaning Logic: Introduced conditional logic within cleanTripHeadsign to apply CleanUtils.keepToAndRemoveVia to the trip headsign only when the new removeVia parameter is set to true. This adds the capability to optionally remove 'Via' prefixes, which was not previously available in this function.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds an option to clean 'via' from trip headsigns. My review points out a potential issue where the implementation does more than just removing 'via', which could be an unintended side-effect based on the naming of the new parameter.