No-code > trip head-sign clean > remove "Via" option

[mmathieum]

• No-code parser > trip head-sign clean > remove "Via" option commons-java#2

[gemini-code-assist]

Summary of Changes

Hello @mmathieum, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the flexibility of trip headsign cleaning by introducing a configurable option to control the removal of "Via" prefixes. This change allows for more granular control over how trip headsigns are processed, enabling specific agencies to decide whether this particular cleaning step is applied.

Highlights

• Configuration: Introduced a new trip_headsign_remove_via boolean option in RouteConfig to enable or disable the removal of "Via" from trip headsigns. This is an opt-in feature, defaulting to false.
• Data Cleaning Logic: Updated the cleanTripHeadsign method in DefaultAgencyTools to utilize the new trip_headsign_remove_via configuration, making the "Via" removal conditional based on the agency's configuration.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new configuration option, tripHeadsignRemoveVia, to control the cleaning of trip headsigns. The implementation correctly adds the new property to RouteConfig and passes it to the StringsCleaner utility.

My main feedback is regarding testing. The new code path for when this feature is enabled is not covered by unit tests in this repository. Adding tests would ensure the configuration is wired correctly and protect against future regressions. I've added a comment with more details.