Skip to content

[Chip] Enable generic props #15052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 26, 2019
Merged

[Chip] Enable generic props #15052

merged 2 commits into from
Mar 26, 2019

Conversation

sperry94
Copy link
Contributor

@sperry94 sperry94 commented Mar 25, 2019 •
edited
Loading

Adding TS examples for the Chips and OutlinedChips examples.

NOTE: There are TS errors that could not be easily resolved that I need some insight on. These errors have to do with the component='a' lines in each of the tsx files, where the compiler doesn't seem to identify a as a valid option for the component prop.

Issue: #14897

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 25, 2019 •
edited
Loading

No bundle size changes comparing 3a8f79a...593cce1

Generated by 🚫 dangerJS against 593cce1

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation typescript labels Mar 25, 2019
@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 25, 2019 •
edited
Loading

@sperry94 It seems we need to apply #15040 for the Chip component. Does it make sense?

@sperry94
Copy link
Contributor Author

@sperry94 It seems we need to apply #15040 for the Chip component. Does it make sense?

Yup! I will make that change! Thanks for the guidance!

@sperry94
Copy link
Contributor Author

@oliviertassinari ok! should be good to go now!

@eps1lon eps1lon added the component: chip This is the name of the generic UI component, not the React module! label Mar 26, 2019
@eps1lon eps1lon merged commit 6981a04 into mui:next Mar 26, 2019
@eps1lon
Copy link
Member

eps1lon commented Mar 26, 2019

@sperry94 Much appreciated, thanks!

@eps1lon eps1lon mentioned this pull request Mar 26, 2019
Closed
@eps1lon eps1lon changed the title [docs] Add TS examples for Chips and OutlinedChips [Chip] Enable generic props Mar 26, 2019
@sperry94 sperry94 deleted the ts-docs-chips-outlined-chips branch March 26, 2019 13:22
@eps1lon eps1lon mentioned this pull request Apr 2, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: chip This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sperry94 @mui-pr-bot @oliviertassinari @eps1lon