🧪 Organize benchmark tests and run simulation in C++ - #2402
Open
denialhaag wants to merge 6 commits into
Open
Conversation
12 tasks
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
denialhaag
marked this pull request as ready for review
September 7, 2026 11:38
denialhaag
force-pushed
the
codex/streamline-benchmark-tests
branch
from
September 7, 2026 11:42
ba9d92c to
7c2a02b
Compare
burgholzer
approved these changes
Sep 7, 2026
burgholzer
left a comment
Member
There was a problem hiding this comment.
This one definitely looks good already! Aiming for merging all four PRs in the stack at once, when possible.
Assisted-by: GPT-5.6 Sol via Codex
Assisted-by: GPT-5.6 Sol via Codex
Use the compiler sampling entry point to handle lowering. Assisted-by: GPT-6 via Codex
burgholzer
force-pushed
the
codex/streamline-benchmark-tests
branch
from
September 7, 2026 13:43
7c2a02b to
fcba621
Compare
Share native generation and sampling checks. Keep Python tests focused on bindings and organize them by benchmark. Move the existing DD phase-table support here so QPE sampling runs at the base of the stack. Assisted-by: GPT-6 via Codex
denialhaag
commented
Sep 7, 2026
Assisted-by: GPT-5.6 Sol via Codex
Assisted-by: GPT-5.6 Sol via Codex
Contributor
|
Important Approval pendingCodeRabbit has no unresolved comments, but it has not reviewed the latest commit. Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Organize C++ generator tests and Python binding tests by benchmark family. Share generation, QCO compilation, sampling, and jeff round-trip checks in the native test utilities.
Run multiplexer, QFT, and QPE sampling checks in C++, using the default compiler pipeline and DD sampler. Include the existing bounded f64 phase-table support needed for direct QPE execution. Python tests cover typed options, JSON round trips, exceptions, and program bindings; dedicated simulator-binding tests already cover the public sampling API.
AI notice
This PR and its contents were created with the assistance of GPT-5.6 Sol and GPT-6 via Codex.
Checklist
I have updated the documentation to reflect these changes.I have added migration instructions to the upgrade guide (if needed).If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).