Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing extension check tests #1313

Merged
merged 5 commits into from
Feb 9, 2025
Merged

Fix failing extension check tests #1313

merged 5 commits into from
Feb 9, 2025

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Feb 9, 2025

This is a rebased version of #1297

mahendrapaipuri and others added 5 commits February 9, 2025 16:00
* To debug the issue causing failures

Signed-off-by: Mahendra Paipuri <[email protected]>
since it is not needed anymore

#1297 (comment)
Copy link

github-actions bot commented Feb 9, 2025

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab or Binder:notebook.

Also, the version of Jupytext developed in this PR can be installed with pip:

HATCH_BUILD_HOOKS_ENABLE=true pip install git+https://github.com/mwouts/jupytext.git@pr_1297_rebased

(this requires nodejs, see more at Developing Jupytext)

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.04%. Comparing base (b3c8c50) to head (b249fb1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1313      +/-   ##
==========================================
+ Coverage   97.02%   97.04%   +0.02%     
==========================================
  Files          29       29              
  Lines        4499     4499              
==========================================
+ Hits         4365     4366       +1     
+ Misses        134      133       -1     
Flag Coverage Δ
external 75.07% <ø> (?)
functional 88.39% <ø> (?)
integration 77.28% <ø> (?)
unit 66.48% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwouts mwouts marked this pull request as ready for review February 9, 2025 16:14
@mwouts mwouts merged commit 5e6cda4 into main Feb 9, 2025
30 checks passed
@mwouts mwouts deleted the pr_1297_rebased branch February 9, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants