Sub feat/crud genre song albums #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myndaaa
changed the base branch from
feature/crud-and-route
to
sub-feat/crud-artists-bands
backend/app/api/v1/genre.py
Outdated
| return genre | ||
|
|
||
|
|
||
| @router.get("/name/{name}", response_model=GenreOut) |
Collaborator
There was a problem hiding this comment.
Remove this API. Use a query-param to the GET genre API
Owner
Author
There was a problem hiding this comment.
Pushed updates and changes
backend/app/api/v1/genre.py
Outdated
| current_admin: dict = Depends(get_current_admin) | ||
| ): | ||
| """Create a new genre - admin only""" | ||
| if genre_name_taken(db, genre_data.name): |
Collaborator
There was a problem hiding this comment.
Can we do the same thing by only one database call?
Owner
Author
There was a problem hiding this comment.
can use integrity error to throw an exception, looked it up working similarly to how it works for CREATE ... IF NOT EXISTS in raw sql
backend/app/api/v1/song.py
Outdated
| return get_all_songs_paginated(db, skip=skip, limit=limit) | ||
|
|
||
|
|
||
| @router.get("/search", response_model=List[SongOut]) |
Collaborator
There was a problem hiding this comment.
Remove this API and add required query-params to the GET API route.
- genre search is case insensitive - genre name taken check is case insensitive - no redundant double GET endpoints for genre, only one get endpoint to get all and get via query param. - Get endpoint allows close matches - fixed redundant and useless usage of /admin endpoints to : no deletion option for genre, only disable option., admin see all genre others only active ones - single db call for genre create, removed prechecks and returning exception error based on crud returns
…as {name} in endpoints which might have whitespaces.
- added fuzzy search to song.
- rmeoved /search endpoint in song and resuing current get endpoint with query params
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: TO BE APPROVED AFTER
sub-feat/crud-userbands, foreign key touserdata model to store who is the owner of thebandviacreated_by_user_idto enforce stricter rbac