test: Add coverage for runner health monitor #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
|
There might be a timing issue here, I'll take a closer look tomorrow. |
tomi
reviewed
Nov 29, 2024
tomi
previously approved these changes
Nov 29, 2024
| panic(fmt.Errorf("failed to terminate runner process: %v", err)) | ||
| } | ||
| logs.Debug("Stopped monitoring runner health") | ||
| logs.Warn("Found runner unresponsive too many times, terminating runner...") |
There was a problem hiding this comment.
Since this no longer does the termination, we could move this log to where it's actually terminated
Makefile
Outdated
Comment on lines
31
to
32
| test-uncached: | ||
| go test -count=1 ./... |
There was a problem hiding this comment.
What does this do? Could we add a comment?
There was a problem hiding this comment.
Added while testing but not really useful, removed.
Edit: To elaborate, Go caches successful test results by default and I was checking if there were any timing issues by running the same tests multiple times. No need now that this was all refactored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/n8n/issue/PAY-2247/write-tests-for-launcher