Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add coverage for runner health monitor #39

Merged
merged 14 commits into from
Dec 2, 2024
Prev Previous commit
Next Next commit
Clearer comments
ivov committed Nov 28, 2024

Verified

This commit was signed with the committer’s verified signature.
ivov Iván Ovejero
commit de5c094e2b1c22b6c3f56e9ff134b348d8a029d1
4 changes: 2 additions & 2 deletions internal/http/monitor_runner_health_test.go
Original file line number Diff line number Diff line change
@@ -86,7 +86,7 @@ func TestMonitorRunnerHealth(t *testing.T) {

select {
case <-waitCh:
// monitoring goroutine was shut down within timeout
// success case - monitoring stopped properly
case <-time.After(100 * time.Millisecond):
t.Fatal("Test timed out waiting for monitor to stop")
}
@@ -142,7 +142,7 @@ func TestMonitorRunnerHealthFailure(t *testing.T) {

select {
case <-waitCh:
// monitoring goroutine was shut down within timeout
// success case - monitoring stopped properly
case <-time.After(100 * time.Millisecond):
t.Fatal("Test timed out waiting for monitor to stop")
}