-
Notifications
You must be signed in to change notification settings - Fork 130
fix: add alias - shielded for all gas spendnig keys #2280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be done a bit differently. We should consider source of the tx as either transparent address or viewing key(for shielded source). The source "address" is encoded PseudoExtendedKey. You can extend the impl with to_viewing_key
(or something like that) method that returns this. Later on you can just call encode
and use in UI as zvknam...
value
Good call, I've updated to now show the viewing key there. Thanks for that explanation 🤝 ![]() |
96f7453
to
a5d1f99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I think we can wrap getChain
, isExtendedKey
and getEncodedViewingKey
in the useCallback also
EDIT: btw I think you need to rebase the branch with main for CI to pass
Also now that refactor is merged you need to add some of the changes to this repo |
a5d1f99
to
36b957d
Compare
No description provided.