Skip to content

Conversation

neocybereth
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@mateuszjasiuk mateuszjasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be done a bit differently. We should consider source of the tx as either transparent address or viewing key(for shielded source). The source "address" is encoded PseudoExtendedKey. You can extend the impl with to_viewing_key (or something like that) method that returns this. Later on you can just call encode and use in UI as zvknam... value

@neocybereth
Copy link
Collaborator Author

I think this should be done a bit differently. We should consider source of the tx as either transparent address or viewing key(for shielded source). The source "address" is encoded PseudoExtendedKey. You can extend the impl with to_viewing_key (or something like that) method that returns this. Later on you can just call encode and use in UI as zvknam... value

Good call, I've updated to now show the viewing key there. Thanks for that explanation 🤝

Screenshot 2025-08-20 at 3 57 46 PM

@neocybereth neocybereth force-pushed the fix/gas-shielding-key-txn-receipt branch from 96f7453 to a5d1f99 Compare August 20, 2025 21:45
Copy link
Collaborator

@mateuszjasiuk mateuszjasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think we can wrap getChain, isExtendedKey and getEncodedViewingKey in the useCallback also

EDIT: btw I think you need to rebase the branch with main for CI to pass

@mateuszjasiuk
Copy link
Collaborator

Also now that refactor is merged you need to add some of the changes to this repo

@neocybereth neocybereth force-pushed the fix/gas-shielding-key-txn-receipt branch from a5d1f99 to 36b957d Compare August 26, 2025 04:56
@neocybereth neocybereth merged commit aba80b7 into main Aug 26, 2025
4 of 5 checks passed
@neocybereth neocybereth deleted the fix/gas-shielding-key-txn-receipt branch August 26, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants