v0.51.5 — 4-PR full-sweep batch#1713
Merged
Merged
Conversation
The file-tree row tooltip says 'Double-click to rename' on every entry, but folders don't actually rename on double-click — they navigate via loadDir(). The tooltip is therefore misleading on directory rows. Reported by @Deor in the WebUI Discord testers thread (May 5 2026): 'Ah that works yeah. May want to change the popup text as it also says double click at the moment.' Fix: gate the tooltip on item.type !== 'dir' so it only attaches to file rows, where double-click does what the hint advertises. Folder rename still reachable via the right-click context menu (unchanged). Companion to #1698/#1702/#1707 — completes the rename-affordance triage: - #1698 fixed: dblclick rename was unreachable on files (preview hijacked) - #1707 fixed: single-click on filename did nothing (over-aggressive guard) - #1710 (this PR): tooltip claimed dblclick-rename on folders too Closes #1710 Tests: 4 source-level regression tests in tests/test_1710_folder_tooltip.py guard the gate, the unchanged dir-dblclick navigate behaviour, the i18n key, and that files still receive the tooltip. All 13 file-tree handler tests (4 new + 9 from #1707) pass.
…ceededError On some setups the localStorage quota is exhausted; the bare setItem call throws an unhandled DOMException that breaks model selection and prevents the chat UI from loading. Wrap both call-sites (boot.js model-select onChange, onboarding.js _saveOnboardingDefaults) in try/catch so the error is logged to the console as a warning instead of surfacing as a fatal exception. Fixes: 'Failed to execute setItem on Storage: Setting the value of hermes-webui-model exceeded the quota.'
4 PRs (1 surface addition, 3 fixes): - #1688 VPS resource health Insights panel (@Michaelyklam, closes #693) - #1709 preserve scroll on stream completion (@Michaelyklam, closes #1690) - #1711 hide rename tooltip on folders (@nesquena-hermes, closes #1710) - #1712 guard localStorage.setItem against QuotaExceededError (@24601) Tests: 4504 → 4527 (+23). Opus: SHIP, 6/6 verification clean. Held back: #1686 (Docker enhance) — Opus flagged sibling-repo dep that breaks standalone clones. Left open for follow-up. Co-authored-by: Michael Lam <Michaelyklam1@gmail.com> Co-authored-by: 24601 <noreply@github.com>
This was referenced May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.51.5 — 4-PR full-sweep batch
Constituent PRs
Additions (1):
Fixes (3):
localStorage.setItemagainst QuotaExceededErrorTests
4504 → 4527 passing (+23 regression tests). 0 regressions. Full suite ~130s.
Pre-release verification
node -c)./api/system/healthreturns sanitized JSON, system health card renders in Insights with Live badge + 3 progress bars (vision-rated 9.5/10), system health card NOT in top chrome (per maintainer placement feedback), sidebar scroll holds at 400px (carry-over from v0.51.2),_scrollAfterMessageRender4-branch behavioral test all correct.Notes on the sweep
docker-compose.ymlbuild context: ..andCOPY hermes-agent-desktop/...Dockerfile additions assume a siblinghermes-agent-desktop/at clone time. Standalone clones would break. Left open for follow-up.console.warn). v2 adopted.Closes #693, #1690, #1710.