feat: separate CLI sessions in sidebar#2506
Conversation
8bc973d to
784a0e6
Compare
|
@Michaelyklam Can you update the screen shots so I can see the before and after? |
784a0e6 to
3b4f62d
Compare
|
Rebased this on current Verification on the rebased head:
|
3b4f62d to
86251f6
Compare
|
Rebased this branch on current Verification on the rebased head:
The PR is mergeable again on the latest head. |
86251f6 to
a48e47d
Compare
|
Rebased this on current Verification on the rebased head:
|
|
Rebased this branch onto current Verification on the rebased head
The PR is mergeable again. |
|
Holding for UX reconsideration. After reviewing the rebased + tested implementation with the maintainer: What works
Hold reason Three rows of click-targets above the conversation list is more discoverable surface than the user really needs, and it leaves room for misclick / wrong-filter confusion. The source filter (WebUI vs CLI) and the project filter are conceptually different axes that both deserve representation, but stacking both as horizontal chip rows isn't the right shape. What we'd like to explore instead (open to discussion, not prescribing the answer):
We want to keep the functional improvement — just not the additional always-visible chip row.
|
08e9ce3
|
Merged in Release DM / v0.51.141 (stage-batch23 — 4-PR second hold-bucket pass with PRs #2506 #2792 #2888 #2958). Thanks @Michaelyklam! 🚢 |
# Conflicts: # CHANGELOG.md
Thinking Path
What Changed
CLI sessionstab with counts.Why It Matters
Verification
env -u HERMES_CONFIG_PATH -u HERMES_WEBUI_HOST /home/michael/.hermes/hermes-agent/venv/bin/python -m pytest tests/test_issue2351_cli_session_source_filter.py -q— 3 passednode --check static/sessions.jsgit diff --checkUI Media
Before — CLI rows mixed into the same sidebar list:
After — separate WebUI/CLI source tabs:
Risks / Follow-ups
Refs #2351
Model Used
AI-assisted change with repository inspection, targeted editing, shell-based test verification, and screenshot capture.