Skip to content

Conversation

jotak
Copy link
Member

@jotak jotak commented Oct 3, 2025

Description

  • Remove some details of the default alerts (thresholds & variants) , just describe the templates
  • Add a section that describes metadata & the health annotation
  • Move the embedded sample YAML into an actual sample

- Remove some details of the default alerts (thresholds & variants) ,
  just describe the templates
- Add a section that describes metadata & the health annotation
Copy link

openshift-ci bot commented Oct 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign msherif1234 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.73%. Comparing base (dbce689) to head (4d583a6).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2070      +/-   ##
==========================================
+ Coverage   71.72%   71.73%   +0.01%     
==========================================
  Files          80       80              
  Lines       10677    10689      +12     
==========================================
+ Hits         7658     7668      +10     
- Misses       2617     2619       +2     
  Partials      402      402              
Flag Coverage Δ
unittests 71.73% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jotak jotak requested review from gwynnemonahan and memodi October 6, 2025 07:43
@jotak jotak added the needs-review Tells that the PR needs a review label Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Tells that the PR needs a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant