Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add utility library to encode text for retrieval #80

Merged
merged 20 commits into from
Jun 2, 2023
Merged

Add utility library to encode text for retrieval #80

merged 20 commits into from
Jun 2, 2023

Conversation

viswavi
Copy link
Collaborator

@viswavi viswavi commented May 29, 2023 •
edited
Loading

Description

This PR provides convenient utility functions that use the Tevatron library's primitives to encode text (either queries or documents) to use for retrieval purposes.

References

N/A

Blocked by

N/A

@viswavi viswavi requested a review from zhaochenyang20 May 29, 2023 03:14
@viswavi viswavi mentioned this pull request May 29, 2023
Merged
zhaochenyang20
zhaochenyang20 requested changes May 29, 2023
View reviewed changes
Copy link
Collaborator

@zhaochenyang20 zhaochenyang20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several changes. And I need more time to dive into tevatron.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
prompt2model/utils/tevatron_utils/encode.py Show resolved Hide resolved
prompt2model/utils/tevatron_utils/encode.py Outdated Show resolved Hide resolved
prompt2model/utils/tevatron_utils/encode.py Outdated Show resolved Hide resolved
prompt2model/utils/tevatron_utils/encode.py Outdated Show resolved Hide resolved
zhaochenyang20
zhaochenyang20 requested changes May 29, 2023
View reviewed changes
Copy link
Collaborator

@zhaochenyang20 zhaochenyang20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several changes. And I feel sorry to say I need more time to dive into tevatron.

prompt2model/utils/tevatron_utils/encode.py Outdated Show resolved Hide resolved
prompt2model/utils/tevatron_utils/retrieve.py Outdated Show resolved Hide resolved
prompt2model/utils/tevatron_utils/retrieve.py Outdated Show resolved Hide resolved
tests/tevatron_utils_test.py Outdated Show resolved Hide resolved
prompt2model/utils/tevatron_utils/encode.py Outdated Show resolved Hide resolved
@viswavi viswavi requested a review from zhaochenyang20 June 1, 2023 16:40
zhaochenyang20
zhaochenyang20 approved these changes Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@zhaochenyang20 zhaochenyang20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really Fine!

@viswavi viswavi merged commit 0a4c5d8 into main Jun 2, 2023
@viswavi viswavi deleted the vijay_retriever_utils branch June 2, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaochenyang20 zhaochenyang20 zhaochenyang20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viswavi @zhaochenyang20