Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retrieve function to tevatron utils #81

Merged
merged 27 commits into from
Jun 2, 2023

Conversation

viswavi
Copy link
Collaborator

@viswavi viswavi commented May 29, 2023

Description

This provides a light rapper over the Tevatron FAISS retriever class to retrieve the vectors with the greatest inner product with a query.

References

Largely based on:
https://github.com/texttron/tevatron/blob/main/src/tevatron/faiss_retriever/__main__.py#L20-L28

Blocked by

#80

@zhaochenyang20 zhaochenyang20 changed the base branch from main to vijay_retriever_utils May 29, 2023 12:42
Copy link
Collaborator

@zhaochenyang20 zhaochenyang20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viswavi viswavi requested a review from zhaochenyang20 June 1, 2023 16:40
Copy link
Collaborator

@zhaochenyang20 zhaochenyang20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from vijay_retriever_utils to main June 2, 2023 14:40
@viswavi viswavi merged commit 5beb4e1 into main Jun 2, 2023
@viswavi viswavi deleted the vijay_add_retrieve_function_to_tevatron_utils branch June 2, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants