fix(macOS): microphone crash on screen sharing #1023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
changed the title
Signed-off-by: Grigorii K. Shartsev <[email protected]>
ShGKme
force-pushed
the
fix/macos-screensharing
branch
from
9132d2e to
d67a778
Compare
Antreesy
approved these changes
Jan 15, 2025
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Sounds good for a quick solution
ShGKme
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Requesting an entire desktop with a stream with audio is not actually supported in macOS. Somehow an attempt to request it results in losing audio devices access with
Current workaround is as simple as removing an unsupported option.
An alternative is to use experimental native screen sharing selector. But it is more complex, requires changes on the Talk side and loses an Entire desktop option for Windows and Linux.
Screenshots
See mic icon. Before it is off and disabled due to an error.