Skip to content

fix(macOS): microphone crash on screen sharing #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix(macOS): microphone crash on screen sharing #1023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/talk/renderer/components/DesktopMediaSourceDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,11 @@ const requestDesktopCapturerSources = async () => {
name: screens.length > 1 ? t('talk_desktop', 'Audio + All screens') : t('talk_desktop', 'Audio + Screen'),
}

// On Wayland we don't manually provide the source stream. It is covered by Wayland and entire-desktop is not supported
sources.value = window.systemInfo.isWayland ? [...screens, ...windows] : [...screens, entireDesktop, ...windows]
// Wayland uses the system picker via PipeWire to select the source.
// Thus, only the selected source is available, and the custom entire-desktop option is neither supported nor needed.
// On macOS the entire-desktop captures only the primary screen and capturing system audio crashes audio (microphone).
// TODO: use the system picker on macOS Sonoma and later
sources.value = window.systemInfo.isWayland || window.systemInfo.isMac ? [...screens, ...windows] : [...screens, entireDesktop, ...windows]
}

const handleVideoSuspend = (source) => {
Expand Down