-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix languageserver errors #726
base: dev
Are you sure you want to change the base?
Conversation
nf-core 3.3.0 release
Two PRs that fix language server errors in modules: |
Should I also format the local modules and subworflows with the LSP formatter as part of this PR? What do you think about that @jfy133? |
IMO unless it's something we can enforce (e.g. through a linting check) it's probably not super important as future PRs might change this? |
Sure, you're right on that, using a linting check would be better to keep a consistent style over time. |
This PR solves errors/warings reported by the Nextflow language server.
Mostly reused variable names and unused variables.
Additionally, I applied module updates that include error fixes.
PR checklist
nf-core pipelines lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).