Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix languageserver errors #726

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

dialvarezs
Copy link
Contributor

@dialvarezs dialvarezs commented Dec 9, 2024

This PR solves errors/warings reported by the Nextflow language server.
Mostly reused variable names and unused variables.
Additionally, I applied module updates that include error fixes.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@dialvarezs dialvarezs marked this pull request as draft December 9, 2024 06:08
@dialvarezs dialvarezs changed the base branch from master to dev December 9, 2024 06:09
@nf-core nf-core deleted a comment from github-actions bot Dec 9, 2024
@dialvarezs dialvarezs changed the title Solve languageserver errors Fix languageserver errors Dec 9, 2024
@prototaxites
Copy link
Contributor

Two PRs that fix language server errors in modules:

nf-core/modules#7432
nf-core/modules#7431

@dialvarezs dialvarezs marked this pull request as ready for review February 16, 2025 19:52
@dialvarezs
Copy link
Contributor Author

Should I also format the local modules and subworflows with the LSP formatter as part of this PR? What do you think about that @jfy133?

@prototaxites
Copy link
Contributor

Should I also format the local modules and subworflows with the LSP formatter as part of this PR? What do you think about that @jfy133?

IMO unless it's something we can enforce (e.g. through a linting check) it's probably not super important as future PRs might change this?

@dialvarezs
Copy link
Contributor Author

Should I also format the local modules and subworflows with the LSP formatter as part of this PR? What do you think about that @jfy133?

IMO unless it's something we can enforce (e.g. through a linting check) it's probably not super important as future PRs might change this?

Sure, you're right on that, using a linting check would be better to keep a consistent style over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants