Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nf-test for somalier/ancestry #7380

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GallVp
Copy link
Member

@GallVp GallVp commented Jan 27, 2025

Added nf-test for somalier/ancestry with pytest2nf-test

@GallVp GallVp requested a review from a team as a code owner January 27, 2025 20:50
@GallVp GallVp requested a review from SPPearce January 27, 2025 20:51
@GallVp GallVp force-pushed the nf-test/somalier_ancestry branch from db9b4c2 to 5b5a242 Compare January 27, 2025 21:10
Copy link
Contributor

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some intial thoughts :)

@@ -22,8 +22,6 @@ process SOMALIER_ANCESTRY {

script:
def args = task.ext.args ?: ''
def prefix = task.ext.prefix ?: "${meta.id}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed because it cannot be used?

Comment on lines +24 to +25
labelled_somalier_tar = file("https://zenodo.org/record/3479773/files/1kg.somalier.tar.gz")
input[0] = [[id:"1kg"],labelled_somalier_tar]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
labelled_somalier_tar = file("https://zenodo.org/record/3479773/files/1kg.somalier.tar.gz")
input[0] = [[id:"1kg"],labelled_somalier_tar]
input[0] = [ [id:"1kg"], file("https://zenodo.org/record/3479773/files/1kg.somalier.tar.gz") ]

Comment on lines +39 to +40
whole_genome_sommalier = file("https://github.com/nf-core/test-datasets/raw/modules/data/delete_me/somalier/whole_genome.somalier", checkIfExists: true)
labels = file("https://github.com/brentp/somalier/raw/73db124d3fe9febe3a53787707554f863595b48f/scripts/ancestry-labels-1kg.tsv", checkIfExists: true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these probably need to be moved from delete_me and also both to the test_datasets repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants