Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QUILT #7508

Merged
merged 10 commits into from
Feb 25, 2025
Merged

Update QUILT #7508

merged 10 commits into from
Feb 25, 2025

Conversation

LouisLeNezet
Copy link
Contributor

PR checklist

Update QUILT modules to handle sample renaming and genfiles.
The nf-test now use the files available outside the delete_me folder.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Copy link
Contributor

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would just move the setup config :) and then just have one nextflow.config file as described here: https://nf-co.re/docs/guidelines/components/modules#configuration-of-extargs-in-tests

@LouisLeNezet LouisLeNezet requested a review from famosab February 24, 2025 14:54
Copy link
Contributor

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last comment :)

@LouisLeNezet LouisLeNezet requested a review from famosab February 25, 2025 08:29
@LouisLeNezet LouisLeNezet added this pull request to the merge queue Feb 25, 2025
Merged via the queue into nf-core:master with commit c6169fa Feb 25, 2025
24 checks passed
@LouisLeNezet LouisLeNezet deleted the quilt branch February 25, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants