Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update STITCH #7510

Merged
merged 12 commits into from
Feb 25, 2025
Merged

Update STITCH #7510

merged 12 commits into from
Feb 25, 2025

Conversation

LouisLeNezet
Copy link
Contributor

@LouisLeNezet LouisLeNezet commented Feb 23, 2025

PR checklist

STITCH can now rename the sample names with a txt file.
It is also updated to the latest version and the posfile, ... are now in the first tuple to simplify parralellization

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@LouisLeNezet LouisLeNezet requested a review from famosab February 24, 2025 14:05
@LouisLeNezet LouisLeNezet requested a review from famosab February 24, 2025 15:17
Copy link
Contributor

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way you assert the output files is new to me but according to the snapshot it works so I would say LGTM!

@LouisLeNezet LouisLeNezet added this pull request to the merge queue Feb 25, 2025
@LouisLeNezet
Copy link
Contributor Author

Thanks for your review @famosab. Don't hesitate if you have one 😉

Merged via the queue into nf-core:master with commit fdc0ff3 Feb 25, 2025
36 checks passed
@LouisLeNezet LouisLeNezet deleted the stitch branch February 25, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants