-
Notifications
You must be signed in to change notification settings - Fork 912
🔧 update image and bioconda container for VueGen to latest version #9201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
nf-core modules patch vuegen, related to PR nf-core/modules#9201
|
Please request to join the github org in slack :) under #github-invitations, you can join slack here https://nf-co.re/join |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can add something that renders the versions.yml file to the nf-test file because it seems to me that the versions are not correctly rendered in the snap :)
I think you can find it in other modules but you will need to adjust the .nf.test file and add
path(process.out.versions[0]).yaml
- had no command line interface option to display version, see Multiomics-Analytics-Group/vuegen#167
|
I saw that the
Is the other change something different? |
Its helpful for a reviewer to not only see the version md5sum but how its actually printed in the end. So I would like to see that :) Its just one line added to the nf.test file. |
|
Ok. I get it know. So when specifying in then the snapshot displays the file content of a yaml file in a structured way: |
modules/nf-core/vuegen/main.nf
Outdated
| label 'process_single' | ||
| conda "${moduleDir}/environment.yml" | ||
| container "dtu_biosustain_dsp/vuegen:v0.3.2-nextflow" | ||
| container "dtu_biosustain_dsp/vuegen:v0.5.1-nextflow" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get this container moved to the nf-core quay.io please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I need special permission? are there instructions for moving it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a core member (like me) needs to do it. could you prepare it according to step 2 here please https://nf-co.re/docs/checklists/community_governance/core_team#making-custom-docker-containers-for-modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. We have a Dockerfile and I will add it to the module here, see: Multiomics-Analytics-Group/nf-vuegen#1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that most core modules 'only' have a conda environment file. Would you then auto-build the docker container (I like wave, but so far i think one has to either use wave or docker, and cannot 'just' use wave for modules which do not have their own docker images)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you have everything in a conda env file, you can just use seqera containers to build docker and singularity images: https://nf-co.re/docs/tutorials/nf-core_components/using_seqera_containers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
- does not pass hadolint(er) as of now
|
I do not get the errors on the CI (actions). Locally it worked, but codespace nf-test fails both for singularity and conda. |
|
looks like a problem with quarto. you should be able to test singularity in github codespaces |
Update VueGen to the latest version.