Skip to content

Conversation

@maxibor
Copy link
Member

@maxibor maxibor commented Oct 17, 2025

PR checklist

RiboDetector is a software developed to accurately yet rapidly detect and remove rRNA sequences from metagenomeic, metatranscriptomic, and ncRNA sequencing data.

  • This comment contains a description of changes (with reason).
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile singularity

@maxibor maxibor requested a review from SPPearce October 24, 2025 09:41
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.
Can you make an issue on the tool github to ask about setting the seed (if it doesn't have already.
I think it would be useful to mention this in the meta.yml too please.

{ assert process.out.fastq },
{ assert process.out.log },
{ assert path(process.out.log[0][1]).getText().contains("Writing output non-rRNA sequences") },
{ assert snapshot(process.out.versions).match("versions") }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ assert snapshot(process.out.versions).match("versions") }
{ assert snapshot(process.out.versions).match() }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants