Conversation
…onality from previous commit.
# GitHub Issue for the Pull Request #529 # GitHub Discussions Related to this Pull Request #509 # Summary of Changes Made a change on `\resource\plugins\NIIconEditor\Miscellaneous\Key Down Up\KeyDown.vi` to recognize the alt key when combined with the ctrl key. # Reason for Change International keyboards (e.g. ENG INTL) are not able to use `ctrl+alt` or `alt gr` to type alternate graphics (e.g. á or µ) on an icon area while using the text tool, since the dropper tool responds to the ctrl key. # Visual Aids <img width="536" height="789" alt="image" src="https://github.com/user-attachments/assets/9329d406-6020-497c-b6cc-a8cb9acbd831" /> # Additional Information ## Manual Tests I built the PPL and replaced it on my 2026 version of LabVIEW, set my keyboard to "ENG INTL", and was able to type alternate graphics. i tried using both `ctrl+alt` and `alt gr` methods, and both worked. This did not affect the ability to select the dropper once you are no longer using the text tool. <img width="426" height="423" alt="image" src="https://github.com/user-attachments/assets/e3833758-a524-4522-9e7f-f0b06092ec48" />
Only diagram and front panel cleanup. No functional changes.
Added steps 35 through 39
Cleaned up KeyDown.vi Added test documentation for new feature
crossrulz
added
Issue group: Bug
There was a problem hiding this comment.
Are there functional changes to this VI? - I couldn't spot anything (but maybe I missed something)
There was a problem hiding this comment.
Good expansion of the tests.
Changing my GB keyboard (with an AltGr key) to US-International to get an AltGr key that works differently made me chuckle but AltGr+m is a nice easy check in small fonts. The easy check on a GB keyboard is AltGr+4 to get € but (I think) small fonts is too old to know about the Euro.
There was a problem hiding this comment.
I tried to have language in there that the US-International was a method to get a AltGr and that µ was an example with that keyboard. I will have see about making this more clear that we just needed to exercise typing a character with the AltGr key and the exact keyboard and character are not important.
There was a problem hiding this comment.
Are we interested in having a copy and paste test where we try and AltGr-C and AltGr-V? It might be a good check to make sure we are handling the funny Ctrl+Alt on windows
There was a problem hiding this comment.
Great work @crossrulz. I have left some comments for you to ponder but they won't stop me approving but I shall leave you to a merge if you are happy.
Kudos to @svelderrainruiz for doing the initial fix. |
Done due to review comment in #533
crossrulz
deleted the
feature/529-pressing-altgr-while-typing-a-text-with-the-text-tool-should-not-switch-to-the-dropper-tool
branch
3 participants
Resolve #529
Updated KeyDown.vi to add a check for Ctrl AND NOT Alt.
Cleanup of KeyDown.vi (no other functional changes)
Added test step in manual tests to type a character that requires the AltGr (µ)