Skip to content

Feature/529 pressing altgr while typing a text with the text tool should not switch to the dropper tool #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crossrulz merged 9 commits into from
Jun 28, 2026
Merged

Feature/529 pressing altgr while typing a text with the text tool should not switch to the dropper tool #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d91a9e5
fix: Allows to use Alt+Gr when using the text tool while inside the i…
svelderrainruiz Jun 4, 2026
b34335e
chore: Cleaned up the VI, this commit introduces no changes to functi…
svelderrainruiz Jun 6, 2026
507c641
fix: Allows to use Alt+Gr when adding text directly to icon (#531)
crossrulz Jun 7, 2026
cdcd107
Cleanup of KeyDown.vi
crossrulz Jun 9, 2026
8d97d1f
Updated 07 Tools.md to satify Markdown Lint
crossrulz Jun 10, 2026
f9eb872
Added typing an AltGr character in Tools Text test
crossrulz Jun 10, 2026
4007d57
Feature/529 pressing altgr while typing a text (#532)
crossrulz Jun 10, 2026
4123b04
Tools test clarification on used keyboard layout
crossrulz Jun 27, 2026
37aeecb
Tools test clarification on used keyboard layout (#536)
crossrulz Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
132 changes: 78 additions & 54 deletions Test/Manual Tests/07 Tools.md
View file
Open in desktop

@j-medland j-medland Jun 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good expansion of the tests.

Changing my GB keyboard (with an AltGr key) to US-International to get an AltGr key that works differently made me chuckle but AltGr+m is a nice easy check in small fonts. The easy check on a GB keyboard is AltGr+4 to get € but (I think) small fonts is too old to know about the Euro.

@crossrulz crossrulz Jun 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to have language in there that the US-International was a method to get a AltGr and that µ was an example with that keyboard. I will have see about making this more clear that we just needed to exercise typing a character with the AltGr key and the exact keyboard and character are not important.

@j-medland j-medland Jun 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we interested in having a copy and paste test where we try and AltGr-C and AltGr-V? It might be a good check to make sure we are handling the funny Ctrl+Alt on windows

Original file line number Diff line number Diff line change
@@ -1,21 +1,28 @@
# Scope
# Tools

## Scope

This procedure is used to verify the functionality of the tools on the Icon Editor.

This procedure was derived from the following NI tests:
- 1692480: Tools test
- 1692488: CTRL and CTRL-Shift actions

- 1692480: Tools test
- 1692488: CTRL and CTRL-Shift actions

Unless otherwise stated, each section of the Main may be ran independently of the other sections. The Setup and Cleanup must be performed.

# Setup
## Setup

1. Open a new VI.
2. Double-click on the icon to open the Icon Editor.
3. Under the Layers tab, delete all layers.
4. Set the Line Color to black (text).
5. Set the Fill Color to red (Thermometer Fill).

# Main
## 1. Pencil
## Main

### 1. Pencil

1. Click on the Pencil tool.
2. Move the cursor to the top-left corner of the icon preview.
3. Verify the cursor is a pencil.
Expand Down Expand Up @@ -51,7 +58,8 @@ Unless otherwise stated, each section of the Main may be ran independently of th
33. Verify the line was cleared.
34. Verify a new layer was not created.

## 2. Line
### 2. Line

1. Click on the Line tool.
2. Move the cursor to the top-left corner of the icon preview.
3. Verify the cursor is a crosshair.
Expand Down Expand Up @@ -81,10 +89,9 @@ Unless otherwise stated, each section of the Main may be ran independently of th
27. Verify the line was cleared.
28. Verify a new layer was not created.

## 3. Fill
1. Using the Line tool, draw a black line from the top-left corner to the bottom-right corner and a second line from the top-right corner to the bottom-left corner.
### 3. Fill

**NOTE:** This is used to create four areas that can be filled and create a Tool layer.
1. Using the Line tool, draw a black line from the top-left corner to the bottom-right corner and a second line from the top-right corner to the bottom-left corner. **NOTE:** This is used to create four areas that can be filled and create a Tool layer.

2. Click on the Fill tool.
3. Move the mouse into the top area of the icon preview.
Expand All @@ -103,10 +110,13 @@ Unless otherwise stated, each section of the Main may be ran independently of th
16. Move the mouse into the right area of the icon preview.
17. Right click.
18. Verify the right area of the icon is blue.

**NOTE:** No cleanup is required here as this setup will be used for the Dropper tool.

## 4. Dropper
### 4. Dropper

**NOTE:** The Fill tool test must be completed to do this test.

1. Click on the Dropper tool.
2. Move the mouse into the bottom area of the icon preview.
3. Verify the cursor is the dropper icon.
Expand Down Expand Up @@ -137,19 +147,20 @@ Unless otherwise stated, each section of the Main may be ran independently of th
28. Verify the Fill Color is now red.
29. Set the Line Color to black (text).
30. Repeat steps 9 through 29 for each of the following tools:
- Line
- Paint
- Rectangle
- Filled Rectangle
- Ellipse
- Filled Ellipse
- Eraser
- Text
- Select
- Move
- Line
- Paint
- Rectangle
- Filled Rectangle
- Ellipse
- Filled Ellipse
- Eraser
- Text
- Select
- Move
31. Delete the Fill layer.

## 5. Rectangle
### 5. Rectangle

1. Click on the Rectangle tool.
2. Move the cursor to the top-left corner of the icon preview.
3. Verify the cursor is a crosshair.
Expand Down Expand Up @@ -186,7 +197,8 @@ Unless otherwise stated, each section of the Main may be ran independently of th
34. Verify a new layer named "Border" was created.
35. Delete the Border layer.

## 6. Filled Rectangle
### 6. Filled Rectangle

1. Click on the Filled Rectangle tool.
2. Move the cursor to the top-left corner of the icon preview.
3. Verify the cursor is a crosshair.
Expand Down Expand Up @@ -223,7 +235,8 @@ Unless otherwise stated, each section of the Main may be ran independently of th
34. Verify a new layer named "Filled" was created.
35. Delete the Filled layer.

## 7. Ellipse
### 7. Ellipse

1. Click on the Ellipse tool.
2. Move the cursor to the top-left corner of the icon preview.
3. Verify the cursor is a crosshair.
Expand Down Expand Up @@ -256,7 +269,8 @@ Unless otherwise stated, each section of the Main may be ran independently of th
30. Verify the ellipse was cleared.
31. Verify a new layer was not created.

## 8. Filled Ellipse
### 8. Filled Ellipse

1. Click on the Filled Ellipse tool.
2. Move the cursor to the top-left corner of the icon preview.
3. Verify the cursor is a crosshair.
Expand Down Expand Up @@ -289,7 +303,8 @@ Unless otherwise stated, each section of the Main may be ran independently of th
30. Verify the ellipse was cleared.
31. Verify a new layer was not created.

## 9. Eraser
### 9. Eraser

1. Double-click the Filled Rectangle tool to fill the icon.
2. Click on the Eraser tool.
3. Move the cursor to near the middle of the icon preview.
Expand All @@ -304,13 +319,16 @@ Unless otherwise stated, each section of the Main may be ran independently of th
12. Verify the pixels the cursor passed over were erased.
13. Delete the Filled layer.

## 10. Text
### 10. Text

**NOTE:** It is recommended to use a keyboard layout that has the AltGr key. For those using an "US" keyboard layout, it is recommended to use the "United States-International" keyboard layout. This layout will make the right Alt key be AltGR.

1. Double-click the Text tool.
2. Verify the Icon Editor Properties window is opened up with the Text Tool category selected.
3. Ensure the following settings:
- Font = Small Fonts
- Alignment = center
- Size = 9
- Font = Small Fonts
- Alignment = center
- Size = 9
4. Click OK to save the settings and close the dialog.
5. Click on the Text tool.
6. Move the cursor to near the middle of the icon preview.
Expand Down Expand Up @@ -342,28 +360,34 @@ Unless otherwise stated, each section of the Main may be ran independently of th
32. Press the ESC button to cancel the operation.
33. Verify the text was cleared.
34. Verify a new layer was not created.
35. Double-click the Text tool to open the Icon Editor Properties.
36. Change the Font to LabVIEW Application and click OK.
37. Click in the icon preview and type "asdf".
38. Verify the font of the typed characters has changed.
39. Double-click the Text tool to open the Icon Editor Properties.
40. Change the Font to Small Fonts and the size to 15. Click OK.
41. Click in the icon preview and type "asdf".
42. Verify the font of the typed characters is larger than before.
43. Double-click the Text tool to open the Icon Editor Properties.
44. Change the size to 9 and the alignment to left. Click OK.
45. Click in the icon preview and type "asdf".
46. Verify the typed characters is left aligned to where the mouse was clicked.
47. Double-click the Text tool to open the Icon Editor Properties.
48. Change the alignment to right. Click OK.
49. Click in the icon preview and type "asdf".
50. Verify the typed characters is right aligned to where the mouse was clicked.
51. Double-click the Text tool to open the Icon Editor Properties.
52. Change the alignment to center. Click OK.
53. Remove any created User Layers.

##

# Cleanup
35. Move the cursor to near the middle of the icon preview.
36. Left click.
37. Type a character that requires the AltGr key. If using the "United States-International" layout, it is recommended to use "µ" (AltGR+m).
38. Verify the character was placed in the icon preview.
39. Press the ESC button to cancel the operation.
40. Double-click the Text tool to open the Icon Editor Properties.
41. Change the Font to LabVIEW Application and click OK.
42. Click in the icon preview and type "asdf".
43. Verify the font of the typed characters has changed.
44. Double-click the Text tool to open the Icon Editor Properties.
45. Change the Font to Small Fonts and the size to 15. Click OK.
46. Click in the icon preview and type "asdf".
47. Verify the font of the typed characters is larger than before.
48. Double-click the Text tool to open the Icon Editor Properties.
49. Change the size to 9 and the alignment to left. Click OK.
50. Click in the icon preview and type "asdf".
51. Verify the typed characters is left aligned to where the mouse was clicked.
52. Double-click the Text tool to open the Icon Editor Properties.
53. Change the alignment to right. Click OK.
54. Click in the icon preview and type "asdf".
55. Verify the typed characters is right aligned to where the mouse was clicked.
56. Double-click the Text tool to open the Icon Editor Properties.
57. Change the alignment to center. Click OK.
58. Remove any created User Layers.

###

## Cleanup

1. Click "Cancel" to close the Icon Editor, discarding any changes.
2. Close the Icon Editor Manual Tests project and any associated files, discarding any changes.
2. Close the Icon Editor Manual Tests project and any associated files, discarding any changes.
Binary file modified resource/plugins/NIIconEditor/Miscellaneous/Clipboard/IE Read from Clipboard.vi
View file
Open in desktop

@j-medland j-medland Jun 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there functional changes to this VI? - I couldn't spot anything (but maybe I missed something)

Binary file not shown.
Binary file modified resource/plugins/NIIconEditor/Miscellaneous/Key Down Up/KeyDown.vi
View file
Open in desktop
Binary file not shown.
Loading