feat(core): Add critial e2e tests file #31242
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 4efdc34.
☁️ Nx Cloud last updated this comment at |
ndcunningham
force-pushed
the
feat/add-e2e-golden-tests
branch
from
1ecf4b3 to
4161227
Compare
fix(react): add missing testing dependency for libraries update
ndcunningham
force-pushed
the
feat/add-e2e-golden-tests
branch
from
4161227 to
4efdc34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new “essential” (aka golden) test file to most packages, think of it as a quick health check that covers each plugin’s absolute must-have functionality.
These tests are kept deliberately small, just enough to prove that the basics still work. If one of these ever fails, it’s a showstopper: we’ll fix it right away to keep our plugins in good shape.
While running the updated e2e tests, we spotted a missing test dependency in the React plugin’s generated library.
This change also brings in
@testing-library/domfor React, so you can run end-to-end and unit tests straight out of the box.Next Steps