Skip to content

feat(core): Add critial e2e tests file #31242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(core): Add critial e2e tests file #31242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
158 changes: 158 additions & 0 deletions e2e/angular/src/angular-essential.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,158 @@
/**
* GOLDEN TEST SUITE — CRITICAL HEALTH CHECK
*
* This file contains the “essential” (aka golden) tests for the
* angular package. It tests the core public API.
*
* FAILURE POLICY
* - If any test here fails, the package is considered broken.
* - Fix the underlying issue immediately, do not merge or release until green.
* - Do not update snapshots here without an accompanying, intentional code change.
*
* GUIDELINES
* - Keep tests small and focused on fundamental behavior.
* - No edge-cases we should only test the critical paths.
* - CI pipelines must block on failures in this file (no skips or timeouts).
*
* MAINTENANCE
* - Whenever you change core behavior, update this file first to cover the new expectations.
* - Add new “essential” tests here only if they test core functionality.
* ──────────────────────────────────────────────────────────────────────────────
*/
import {
checkFilesExist,
cleanupProject,
newProject,
readFile,
runCLI,
uniq,
updateFile,
} from '@nx/e2e/utils';
import { join } from 'node:path';

describe('Angular essential tests', () => {
beforeAll(() => {
newProject({ packages: ['@nx/angular', '@nx/eslint', '@nx/jest'] });
});

afterAll(() => cleanupProject());

describe('Webpack', () => {
it('should be able to generate, build, test and lint an application', async () => {
const appName = uniq('app');

runCLI(
`generate @nx/angular:app apps/${appName} --linter=eslint --bundler=webpack`
);

checkFilesExist(`apps/${appName}/src/app/app.component.ts`);
checkFilesExist(`apps/${appName}/src/app/app.config.ts`);

const buildResult = runCLI(`build ${appName}`);
const lintResult = runCLI(`lint ${appName}`);
const testResult = runCLI(`test ${appName}`);

expect(buildResult).toContain(
`Successfully ran target build for project ${appName}`
);
expect(testResult).toContain(
`Successfully ran target test for project ${appName}`
);
expect(lintResult).toContain(
`Successfully ran target lint for project ${appName}`
);
}, 200_000);
});

describe('Rspack', () => {
it('should be able to generate, build, test and lint an application', async () => {
const appName = uniq('app');

runCLI(
`generate @nx/angular:app apps/${appName} --linter=eslint --bundler=rspack`
);

const rspackConfigFileContents = readFile(
join('apps', appName, 'rspack.config.ts')
);
const updatedConfigFileContents = rspackConfigFileContents.replace(
`maximumError: '1mb'`,
`maximumError: '3mb'`
);
updateFile(
join('apps', appName, 'rspack.config.ts'),
updatedConfigFileContents
);

checkFilesExist(`apps/${appName}/src/app/app.component.ts`);
checkFilesExist(`apps/${appName}/src/app/app.config.ts`);
checkFilesExist(`apps/${appName}/rspack.config.ts`);

const buildResult = runCLI(`build ${appName}`);
const lintResult = runCLI(`lint ${appName}`);
const testResult = runCLI(`test ${appName}`);

expect(buildResult).toContain(
`Successfully ran target build for project ${appName}`
);
expect(testResult).toContain(
`Successfully ran target test for project ${appName}`
);
expect(lintResult).toContain(
`Successfully ran target lint for project ${appName}`
);
}, 200_000);
});

describe('Esbuild (default)', () => {
it('should be able to generate, build, test and lint an application', async () => {
const appName = uniq('app');

runCLI(`generate @nx/angular:app apps/${appName} --linter=eslint`);

checkFilesExist(`apps/${appName}/src/app/app.component.ts`);
checkFilesExist(`apps/${appName}/src/app/app.config.ts`);

const buildResult = runCLI(`build ${appName}`);
const lintResult = runCLI(`lint ${appName}`);
const testResult = runCLI(`test ${appName}`);

expect(buildResult).toContain(
`Successfully ran target build for project ${appName}`
);
expect(testResult).toContain(
`Successfully ran target test for project ${appName}`
);
expect(lintResult).toContain(
`Successfully ran target lint for project ${appName}`
);
}, 200_000);

it('should be able to generate, build, test and lint a library', async () => {
const libName = uniq('lib');

runCLI(
`generate @nx/angular:lib libs/${libName} --linter=eslint --buildable=true`
);

checkFilesExist(`libs/${libName}/src/index.ts`);
checkFilesExist(
`libs/${libName}/src/lib/${libName}/${libName}.component.ts`
);

const buildResult = runCLI(`build ${libName}`);
const lintResult = runCLI(`lint ${libName}`);
const testResult = runCLI(`test ${libName}`);

expect(buildResult).toContain(
`Successfully ran target build for project ${libName}`
);
expect(testResult).toContain(
`Successfully ran target test for project ${libName}`
);
expect(lintResult).toContain(
`Successfully ran target lint for project ${libName}`
);
}, 200_000);
});
});
86 changes: 86 additions & 0 deletions e2e/cypress/src/cypress-essential.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
/**
* GOLDEN TEST SUITE — CRITICAL HEALTH CHECK
*
* This file contains the “essential” (aka golden) tests for the
* cypress package. It tests the core public API.
*
* FAILURE POLICY
* - If any test here fails, the package is considered broken.
* - Fix the underlying issue immediately, do not merge or release until green.
* - Do not update snapshots here without an accompanying, intentional code change.
*
* GUIDELINES
* - Keep tests small and focused on fundamental behavior.
* - No edge-cases we should only test the critical paths.
* - CI pipelines must block on failures in this file (no skips or timeouts).
*
* MAINTENANCE
* - Whenever you change core behavior, update this file first to cover the new expectations.
* - Add new “essential” tests here only if they test core functionality.
* ──────────────────────────────────────────────────────────────────────────────
*/

import {
checkFilesExist,
cleanupProject,
newProject,
runCLI,
runE2ETests,
uniq,
} from '@nx/e2e/utils';

describe('Cypress essential tests', () => {
beforeAll(() => {
newProject({ packages: ['@nx/react', '@nx/angular', '@nx/cypress'] });
});

afterAll(() => cleanupProject());

describe('React', () => {
const myapp = uniq('myapp');
it('should generate and run a react app with the Cypress as e2e test runner', () => {
runCLI(
`generate @nx/react:app apps/${myapp} --e2eTestRunner=cypress --linter=none`
);

// Making sure the cypress folders & files are created
checkFilesExist(`apps/${myapp}-e2e/cypress.config.ts`);
checkFilesExist(`apps/${myapp}-e2e/tsconfig.json`);

checkFilesExist(`apps/${myapp}-e2e/src/fixtures/example.json`);
checkFilesExist(`apps/${myapp}-e2e/src/e2e/app.cy.ts`);
checkFilesExist(`apps/${myapp}-e2e/src/support/app.po.ts`);
checkFilesExist(`apps/${myapp}-e2e/src/support/e2e.ts`);
checkFilesExist(`apps/${myapp}-e2e/src/support/commands.ts`);

if (runE2ETests('cypress')) {
const result = runCLI(`e2e ${myapp}-e2e`);
expect(result).toContain('All specs passed!');
}
}, 600_000);
});

describe('Angular', () => {
const myapp = uniq('myapp');
it('should generate and run an angular app with the Cypress as e2e test runner', () => {
runCLI(
`generate @nx/angular:app apps/${myapp} --e2eTestRunner=cypress --linter=none`
);

// Making sure the cypress folders & files are created
checkFilesExist(`apps/${myapp}-e2e/cypress.config.ts`);
checkFilesExist(`apps/${myapp}-e2e/tsconfig.json`);

checkFilesExist(`apps/${myapp}-e2e/src/fixtures/example.json`);
checkFilesExist(`apps/${myapp}-e2e/src/e2e/app.cy.ts`);
checkFilesExist(`apps/${myapp}-e2e/src/support/app.po.ts`);
checkFilesExist(`apps/${myapp}-e2e/src/support/e2e.ts`);
checkFilesExist(`apps/${myapp}-e2e/src/support/commands.ts`);

if (runE2ETests('cypress')) {
const result = runCLI(`e2e ${myapp}-e2e`);
expect(result).toContain('All specs passed!');
}
}, 600_000);
});
});
Loading
Loading