Skip to content

fix llvmdev osx64 conda builder #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 17, 2025

Conversation

swap357
Copy link
Contributor

@swap357 swap357 commented Mar 7, 2025

This PR fixes osx64 build for llvmdev conda and wheel builder by setting up macOS sdk compatible to work with conda build on GHA runner.

Copy link
Member

@sklam sklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get the osx wheel tester going with this? It's the best way to test whether the build config changes are ok.

@swap357 swap357 requested a review from sklam March 12, 2025 22:14
@swap357 swap357 mentioned this pull request Mar 18, 2025
20 tasks
@swap357 swap357 force-pushed the gha/fix-llvmdev-osx64-conda-builder branch from 23e41da to 2d497b8 Compare March 25, 2025 19:47
@swap357
Copy link
Contributor Author

swap357 commented Mar 25, 2025

Can we get the osx wheel tester going with this? It's the best way to test whether the build config changes are ok.

the condo package as well as wheel are tested with GHA on this change -
https://github.com/numba/llvmlite/actions/runs/14068772517

@esc
Copy link
Member

esc commented Mar 27, 2025

@swap357 thank you for this. I think in order to test this well, we will need the osx builders for llvmlite and numba.

Copy link
Member

@esc esc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question and one requested change.

@esc
Copy link
Member

esc commented Apr 1, 2025

@swap357 thank you again, now waiting on the llvmlite builders to become available for review such that I can test the artifacts produced from this workflow in earnest.

@seibert seibert merged commit da770cf into numba:main Apr 17, 2025
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants