refactor: ESLint/Sonar compliance — screen folder splits & rule fixes#59

Closed

alichherawalla wants to merge 82 commits into

mainfrom

fix/sonar-download-manager-screen

Commits on Feb 20, 2026

fix(S3358): extract nested ternary into getStatusText helper

alichherawalla
and
claude
committed
fix(S6582): use optional chain for metadata filename check

alichherawalla
and
claude
committed
fix(S2486): handle caught exceptions with error logging

alichherawalla
and
claude
committed
fix(S7773): prefer Number.isNaN over global isNaN

alichherawalla
and
claude
committed
fix(S6439): convert quantization string conditional to boolean

alichherawalla
and
claude
committed
fix(S6479): use stable model identifiers as list keys

alichherawalla
and
claude
committed
fix(S6594/S6397): use RegExp.exec and simplify regex character class

alichherawalla
and
claude
committed
fix(S6544/S2004): extract async logic from alert onPress callbacks

alichherawalla
and
claude
committed
test(DownloadManagerScreen): add getStatusText status display coverage

alichherawalla
and
claude
committed
fix(S7748): remove trailing zero fractions from memory threshold constants

alichherawalla
and
claude
committed
test(ios): add XCTest unit-test infrastructure for native Swift modules

alichherawalla
and
claude
committed
fix(S2933): mark listeners and loadingState fields as readonly

alichherawalla
and
claude
committed
chore(ci): move iOS unit tests into ci.yml, remove test-ios.yml

alichherawalla
and
claude
committed
fix(S2094): reduce cognitive complexity of DownloadCompleteBroadcastReceiver.onReceive

alichherawalla
and
claude
committed
chore: add test:android and test:ios to quality gate in CLAUDE.md

alichherawalla
and
claude
committed
ci: add test-android job to CI workflow

alichherawalla
and
claude
committed
fix(S3776): reduce checkMemoryForModel cognitive complexity from 18 to 15

alichherawalla
and
claude
committed
test(ios): expand XCTest suite from 12 to 30 cases across all 3 modules

alichherawalla
and
claude
committed
fix(S7748): remove zero fraction from default guidanceScale in ChatScreen

alichherawalla
and
claude
committed
fix(S3923): remove identical-branch ternary for keyboardVerticalOffset

alichherawalla
and
claude
committed
fix(S6754): destructure useState into setter only when value is unused

alichherawalla
and
claude
committed
fix(S6582): use optional chain for classifierModel filePath check

alichherawalla
and
claude
committed
fix(S7755): use Array.at(-1) instead of bracket length-index access

alichherawalla
and
claude
committed
fix(S1874): replace deprecated String.substr with String.slice

alichherawalla
and
claude
committed
fix(S2486/S7718): handle stop-generation catch block

alichherawalla
and
claude
committed
fix(S2004): pass resolve directly to setTimeout

alichherawalla
and
claude
committed
test(android): add unit tests for DownloadManagerModule and LocalDreamModule helpers

alichherawalla
and
claude
committed
fix(S6544): extract async delete-conversation handler

alichherawalla
and
claude
committed
fix(security): address Gemini review comments on DownloadManagerScreen

alichherawalla
and
claude
committed
fix(S3358): extract nested ternaries in ChatScreen

alichherawalla
and
claude
committed
fix(S3776): reduce ensureModelLoaded cognitive complexity

alichherawalla
and
claude
committed
fix(S1874): replace absoluteFillObject with explicit style properties

alichherawalla
and
claude
committed
fix(S6754): remove unused currentImageMode state

alichherawalla
and
claude
committed
fix(S2004): extract waitForRenderFrame to reduce function nesting depth

alichherawalla
and
claude
committed
fix(S1874): replace deprecated InteractionManager.runAfterInteractions

alichherawalla
and
claude
committed
test(android): fix DownloadManagerModuleTest to use Robolectric for JSONObject support

alichherawalla
and
claude
committed
refactor(android): extract shouldRemoveDownload and saveRgbToPng to companion object

alichherawalla
and
claude
committed
test(android): add saveRgbToPng pixel-accuracy tests to LocalDreamModuleTest

alichherawalla
and
claude
committed
chore(tooling): add Husky pre-commit hooks, expand ESLint rules, add SwiftLint to CI

alichherawalla
and
claude
committed
fix(prefer-template): replace string concatenation with template literals

alichherawalla
and
claude
committed
chore(tooling): add Husky pre-commit hooks, lint-staged, and SwiftLint

alichherawalla
and
claude
committed
test(ChatScreen): use fake timers in conversation-switch KV-cache test

alichherawalla
and
claude
committed
fix(lint): resolve no-shadow and no-empty violations in ChatScreen test

alichherawalla
and
claude
committed
fix(prefer-template): auto-fix remaining string concatenations in tests; remove stale eslint-disable comments

alichherawalla
and
claude
committed
fix(S3776): reduce ChatScreen component cognitive complexity

alichherawalla
and
claude
committed
fix(no-shadow): remove shadowing React require in jest mock factories

alichherawalla
and
claude
committed
Merge branch 'main' of github.com:alichherawalla/offline-mobile-llm-manager into fix/sonar-download-manager-screen
alichherawalla
committed
chore: add .eslintignore for generated build artifacts

alichherawalla
and
claude
committed
chore: sonar connection
alichherawalla
committed

Commits on Feb 21, 2026