refactor: ESLint/Sonar compliance — screen folder splits & rule fixes

.eslintignore

@@ -0,0 +1,4 @@
+# Generated build artifacts
+android/app/build/
+ios/build/
+coverage/

.eslintrc.js

@@ -1,7 +1,19 @@
 module.exports = {
   root: true,
   extends: '@react-native',
+  plugins: [
+    'react-native',
+    'react',
+    'react-hooks',
+  ],
+  env: {
+    jest: true,
+    browser: true,
+    node: true,
+    es6: true,
+  },
   rules: {
+    // TypeScript
     '@typescript-eslint/no-unused-vars': [
       'error',
       {
@@ -10,5 +22,41 @@ module.exports = {
         caughtErrorsIgnorePattern: '^_',
       },
     ],
+    'no-shadow': 'off',
+    '@typescript-eslint/no-shadow': 'error',
+
+    // Code quality (built-in)
+    'no-empty': 'error',
+    'no-else-return': 'error',
+    'prefer-template': 'error',
+    complexity: ['error', 15],
+    'max-lines-per-function': ['error', 250],
+    'max-lines': ['error', 350],
+    'max-params': ['error', 3],
+    // React hooks
+    'react-hooks/rules-of-hooks': 'error',
+    'react-hooks/exhaustive-deps': 'warn',
+
+    // React Native
+    'react-native/no-unused-styles': 'error',
+    'react-native/no-inline-styles': 'error',
+    'react-native/no-color-literals': 'error',
+    'react-native/no-raw-text': 'error',
+    'react-native/no-single-element-style-arrays': 'error',
   },
+  overrides: [
+    {
+      // Relax structural rules in test files — large test suites and helpers are acceptable
+      files: ['__tests__/**/*', '*.test.ts', '*.test.tsx', 'jest.setup.ts'],
+      rules: {
+        'max-lines': 'off',
+        'max-lines-per-function': 'off',
+        'max-params': 'off',
+        complexity: 'off',
+        'react-native/no-inline-styles': 'off',
+        'react-native/no-raw-text': 'off',
+        'react-native/no-color-literals': 'off',
+      },
+    },
+  ],
 };

.github/workflows/ci.yml

@@ -72,3 +72,86 @@ jobs:
           token: ${{ secrets.CODECOV_TOKEN }}
           files: ./coverage/lcov.info
           fail_ci_if_error: false
+
+  test-android:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Setup Java
+        uses: actions/setup-java@v4
+        with:
+          distribution: 'temurin'
+          java-version: '17'
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+          cache: 'npm'
+
+      - name: Install JS dependencies
+        run: npm ci
+
+      - name: Run Android unit tests
+        run: npm run test:android
+
+      - name: Upload test results
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: android-test-results
+          path: android/app/build/reports/tests/
+          if-no-files-found: ignore
+
+  test-ios:
+    runs-on: macos-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+          cache: 'npm'
+
+      - name: Install JS dependencies
+        run: npm ci
+
+      - name: Setup Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '3.2'
+          bundler-cache: true
+
+      - name: Install CocoaPods
+        run: |
+          gem install cocoapods
+          cd ios && pod install
+
+      - name: Install SwiftLint
+        run: brew install swiftlint
+
+      - name: Lint Swift
+        run: swiftlint lint --quiet --reporter github-actions-logging
+
+      - name: Run iOS unit tests
+        run: |
+          xcodebuild test \
+            -workspace ios/OffgridMobile.xcworkspace \
+            -scheme OffgridMobile \
+            -destination 'platform=iOS Simulator,name=iPhone 16e' \
+            -only-testing:OffgridMobileTests \
+            | xcpretty --color && exit "${PIPESTATUS[0]}"
+
+      - name: Upload test results
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: ios-test-results
+          path: ~/Library/Developer/Xcode/DerivedData/**/Logs/Test/*.xcresult
+          if-no-files-found: ignore

.husky/pre-commit

@@ -0,0 +1,43 @@
+#!/usr/bin/env sh
+
+# Detect staged file types
+STAGED_JS=$(git diff --cached --name-only --diff-filter=ACMR | grep -E '\.(ts|tsx|js|jsx)$' || true)
+STAGED_SWIFT=$(git diff --cached --name-only --diff-filter=ACMR | grep '\.swift$' | grep -v 'Pods/' | grep -v 'build/' || true)
+STAGED_KOTLIN=$(git diff --cached --name-only --diff-filter=ACMR | grep -E '\.(kt|kts)$' || true)
+
+# ── JS / TS ────────────────────────────────────────────────────────────────────
+if [ -n "$STAGED_JS" ]; then
+  echo "▶ JS/TS lint (staged files)..."
+  npx lint-staged
+
+  echo "▶ TypeScript type check..."
+  npx tsc --noEmit
+
+  echo "▶ JS/TS tests..."
+  npm test
+fi
+
+# ── Swift / iOS ────────────────────────────────────────────────────────────────
+if [ -n "$STAGED_SWIFT" ]; then
+  if command -v swiftlint >/dev/null 2>&1; then
+    echo "▶ SwiftLint (staged files)..."
+    echo "$STAGED_SWIFT" | tr '\n' '\0' | xargs -0 swiftlint lint --quiet
+  else
+    echo "⚠️  SwiftLint not installed — skipping Swift lint. Install: brew install swiftlint"
+  fi
+
+  echo "▶ iOS tests..."
+  npm run test:ios
+fi
+
+# ── Kotlin / Android ───────────────────────────────────────────────────────────
+if [ -n "$STAGED_KOTLIN" ]; then
+  echo "▶ Kotlin type check (compileStandardDebugKotlin)..."
+  (cd android && ./gradlew compileStandardDebugKotlin --quiet)
+
+  echo "▶ Android lint..."
+  (cd android && ./gradlew lintStandardDebug --quiet)
+
+  echo "▶ Android tests..."
+  npm run test:android
+fi

.swiftlint.yml

@@ -0,0 +1,26 @@
+included:
+  - ios
+
+excluded:
+  - ios/Pods
+  - ios/build
+  - ios/OffgridMobile.xcodeproj
+  - ios/OffgridMobileTests
+
+disabled_rules:
+  - trailing_whitespace   # handled by editor
+  - line_length           # RN bridge code has long lines
+
+opt_in_rules:
+  - force_unwrapping
+
+force_unwrapping:
+  severity: warning
+
+function_body_length:
+  warning: 100
+  error: 200
+
+type_body_length:
+  warning: 400
+  error: 1000

.vscode/settings.json

@@ -0,0 +1,6 @@
+{
+    "sonarlint.connectedMode.project": {
+        "connectionId": "alichherawalla",
+        "projectKey": "alichherawalla_off-grid-mobile"
+    }
+}

CLAUDE.md

@@ -2,13 +2,19 @@
 
 ## Pre-Commit Quality Gates
 
-Before EVERY commit, you MUST first check if you have added tests for whatever you are trying to commit. If not add tests. Then run all of the following checks and ensure they pass. Do NOT commit until all three are green:
+All quality gates run automatically via Husky on every `git commit`, scoped to the file types you staged:
 
-1. **Tests**: `npm test` — if you wrote or modified code, first ensure tests exist for the changes. Write missing tests before running.
-2. **Linting**: `npm run lint`
-3. **TypeScript**: `npx tsc --noEmit`
+| Staged file type | Checks that run automatically |
+|---|---|
+| `.ts` / `.tsx` / `.js` / `.jsx` | eslint (staged only), `tsc --noEmit`, `npm test` |
+| `.swift` | swiftlint (staged only), `npm run test:ios` |
+| `.kt` / `.kts` | `compileStandardDebugKotlin` (type check), `lintStandardDebug`, `npm run test:android` |
 
-Run all three in parallel. If any fail, fix the issues and re-run until they all pass. Never skip these checks.
+**Requirements:**
+- SwiftLint: `brew install swiftlint` (skipped with a warning if not installed)
+- Android checks require the Gradle wrapper in `android/`
+
+Before writing new code, ensure tests exist for your changes. If the hook fails, fix the issue and recommit — never skip with `--no-verify`.
 
 ## Push = Create PR + Address Review
 

__tests__/integration/generation/generationFlow.test.ts

@@ -74,7 +74,7 @@ describe('Generation Flow Integration', () => {
       let completeCallback: any = null;
 
       mockLlmService.generateResponse.mockImplementation(
-        async (_messages, onStream, onComplete, _onError, _onThinking) => {
+        async (_messages, onStream, onComplete) => {
           streamCallback = onStream!;
           completeCallback = onComplete!;
           return 'Hello world!';
@@ -118,7 +118,7 @@ describe('Generation Flow Integration', () => {
       let completeCallback: any = null;
 
       mockLlmService.generateResponse.mockImplementation(
-        async (_messages, onStream, onComplete, _onError, _onThinking) => {
+        async (_messages, onStream, onComplete) => {
           streamCallback = onStream!;
           completeCallback = onComplete!;
           return 'Test';
@@ -153,7 +153,7 @@ describe('Generation Flow Integration', () => {
       let completeCallback: any = null;
 
       mockLlmService.generateResponse.mockImplementation(
-        async (_messages, onStream, onComplete, _onError, _onThinking) => {
+        async (_messages, onStream, onComplete) => {
           streamCallback = onStream!;
           completeCallback = onComplete!;
           return 'Test';
@@ -186,7 +186,7 @@ describe('Generation Flow Integration', () => {
       let completeCallback: any = null;
 
       mockLlmService.generateResponse.mockImplementation(
-        async (_messages, _onStream, onComplete, _onError, _onThinking) => {
+        async (_messages, _onStream, onComplete) => {
           completeCallback = onComplete!;
           return 'Test';
         }
@@ -214,7 +214,7 @@ describe('Generation Flow Integration', () => {
       let completeCallback: any = null;
 
       mockLlmService.generateResponse.mockImplementation(
-        async (_messages, onStream, onComplete, _onError, _onThinking) => {
+        async (_messages, onStream, onComplete) => {
           streamCallback = onStream!;
           completeCallback = onComplete!;
           return 'Hello world';
@@ -254,7 +254,7 @@ describe('Generation Flow Integration', () => {
       let completeCallback: any = null;
 
       mockLlmService.generateResponse.mockImplementation(
-        async (_messages, onStream, onComplete, _onError, _onThinking) => {
+        async (_messages, onStream, onComplete) => {
           streamCallback = onStream!;
           completeCallback = onComplete!;
           return 'Complete response';
@@ -316,7 +316,7 @@ describe('Generation Flow Integration', () => {
       let completeCallback: any = null;
 
       mockLlmService.generateResponse.mockImplementation(
-        async (_messages, onStream, onComplete, _onError, _onThinking) => {
+        async (_messages, onStream, onComplete) => {
           streamCallback = onStream!;
           completeCallback = onComplete!;
           return 'Response';
@@ -347,11 +347,8 @@ describe('Generation Flow Integration', () => {
       const modelId = setupWithActiveModel();
       const conversationId = setupWithConversation({ modelId });
 
-      let _errorCallback: any = null;
-
       mockLlmService.generateResponse.mockImplementation(
-        async (_messages, _onStream, _onComplete, onError, _onThinking) => {
-          _errorCallback = onError!;
+        async (_messages, _onStream, _onComplete) => {
           throw new Error('Generation failed');
         }
       );
@@ -376,7 +373,7 @@ describe('Generation Flow Integration', () => {
       const conversationId = setupWithConversation({ modelId });
 
       mockLlmService.generateResponse.mockImplementation(
-        async (_messages, _onStream, _onComplete, _onError, _onThinking) => {
+        async (_messages) => {
           // Never complete automatically - simulates ongoing generation
           return new Promise(() => {});
         }
@@ -432,7 +429,7 @@ describe('Generation Flow Integration', () => {
       let streamCallback: any = null;
 
       mockLlmService.generateResponse.mockImplementation(
-        async (_messages, onStream, _onComplete, _onError, _onThinking) => {
+        async (_messages, onStream) => {
           streamCallback = onStream!;
           // Simulate long running generation by returning a never-resolving promise
           await new Promise(() => {});
@@ -481,7 +478,7 @@ describe('Generation Flow Integration', () => {
       let streamCallback: any = null;
 
       mockLlmService.generateResponse.mockImplementation(
-        async (_messages, onStream, _onComplete, _onError, _onThinking) => {
+        async (_messages, onStream) => {
           streamCallback = onStream!;
           return new Promise(() => {});
         }
@@ -511,7 +508,7 @@ describe('Generation Flow Integration', () => {
       const conversationId = setupWithConversation({ modelId });
 
       mockLlmService.generateResponse.mockImplementation(
-        async (_messages, _onStream, _onComplete, _onError, _onThinking) => {
+        async (_messages) => {
           return new Promise(() => {});
         }
       );
@@ -540,7 +537,7 @@ describe('Generation Flow Integration', () => {
       let completeCallback: any = null;
 
       mockLlmService.generateResponse.mockImplementation(
-        async (_messages, onStream, onComplete, _onError, _onThinking) => {
+        async (_messages, onStream, onComplete) => {
           streamCallback = onStream!;
           completeCallback = onComplete!;
           return 'Test';

__tests__/rntl/components/AnimatedPressable.test.tsx

@@ -21,9 +21,9 @@ jest.mock('../../../src/utils/haptics', () => ({
   triggerHaptic: jest.fn(),
 }));
 
-// eslint-disable-next-line @typescript-eslint/no-var-requires
+ 
 const { triggerHaptic: mockTriggerHaptic } = require('../../../src/utils/haptics');
-// eslint-disable-next-line @typescript-eslint/no-var-requires
+ 
 const Reanimated = require('react-native-reanimated');
 
 describe('AnimatedPressable', () => {