chore: adjust spotbugs error level and exclude configuration, with CI change of annotation configuration on GitHub Actions Spotbugs task #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SpotBugs configuration has been removed to simplify the build logic. This change eliminates the specific report level setting while retaining support for generating SpotBugs reports through tasks. Future SpotBugs configurations can now be added explicitly where needed. Signed-off-by: Hiroshi Miura <[email protected]>
|
❌ Quality checks failed. Please look a Gradle Scan page for details: |
This was referenced Mar 17, 2025
miurahr
force-pushed
the
topic/miurahr/build-system/adjust-spotbugs-enable-annotation
branch
from
c0faf01 to
fd2a5d9
Compare
|
❌ Quality checks failed. Please look a Gradle Scan page for details: |
This comment was marked as outdated.
This comment was marked as outdated.
- Introduce a SpotBugs exclusion file and update the Gradle build logic to streamline SpotBugs integration. - Refactor SpotBugs task definitions by consolidating configuration in `verification-conventions.gradle`, removing redundancy from `java-conventions.gradle`, and adding appropriate reporting setup. Signed-off-by: Hiroshi Miura <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Moved and streamlined SpotBugs setup from verification-conventions to java-conventions for better organization. Replaced redundant SpotBugs task with a more versatile reporting function and retained necessary SpotBugs settings in java-conventions. Improved log readability by adding project context and formatted output. Signed-off-by: Hiroshi Miura <[email protected]>
This change introduces a step to run spotbugsReport only on pull requests when a failure occurs. It ensures better visibility into SpotBugs findings during CI workflows. Signed-off-by: Hiroshi Miura <[email protected]>
Updated the workflow to ensure the SpotBugs report step fails the CI on errors. Improved report output formatting for better readability with consistent separators. Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
…n class design issue Signed-off-by: Hiroshi Miura <[email protected]>
Updated `problem-matcher.json` to revert previous wrong change. Signed-off-by: Hiroshi Miura <[email protected]>
Added excludeFilter in SpotBugs configuration to utilize a new exclusion file. Updated exclude.xml to refine bug pattern matching and address application design issues in core classes. These changes aim to suppress non-critical warnings caused by known design constraints. Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
changed the title
Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
…d preferences view classes - filters3 XML classes stores mutable object internally - PluginUtils provides getXXXClasses which expose mutable expose object. - o.o.g.p.view.*Contoller class expose internal object by getGui() method override in design Signed-off-by: Hiroshi Miura <[email protected]>
This was referenced Mar 23, 2025
This was referenced Mar 23, 2025
Revised regex patterns to eliminate unnecessary groups and improve clarity. Updated patterns now match the expected input more precisely and reduce redundancy, ensuring better maintainability and accuracy. Signed-off-by: Hiroshi Miura <[email protected]>
Replaced the deprecated `gradle/wrapper-validation-action` with `gradle/actions/wrapper-validation` in the GitHub Actions workflow. This ensures compatibility with the latest action and improves maintainability. Signed-off-by: Hiroshi Miura <[email protected]>
The Gradle wrapper validation workflow was deleted to streamline CI processes. This action is no longer required, and its removal reduces redundancy in the project's GitHub Actions configuration. - gradle-setup@v4 validate wrapper now, so we don't need to validate separately. Signed-off-by: Hiroshi Miura <[email protected]>
Modified the regular expression to account for "Method invoked at" in addition to existing terms like "Dereferenced at" or "At." This ensures proper matching for a broader range of error messages in CI outputs. Signed-off-by: Hiroshi Miura <[email protected]>
Updated the regex pattern to include new scenarios such as "Obligation to clean up resource created at" and "Redundant null check at." This enhances the matcher’s ability to detect and report these specific issues in logs. Signed-off-by: Hiroshi Miura <[email protected]>
Added new matchers for resource cleanup, method invocation, unsynchronized access, and restructured existing ones for better error categorization. Each matcher includes file, line, message, and code capture groups to improve diagnostic accuracy. This enhances CI's ability to parse and report SpotBugs issues effectively. Signed-off-by: Hiroshi Miura <[email protected]>
brandelune
approved these changes
Mar 29, 2025
brandelune
approved these changes
Mar 29, 2025
This was referenced Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update spotbugs staitc code analysis configuration.
1 . Not limit to HIGH severity but DEFAULT level
2. Update problem-matcher.json for GitHub Actions
3. Improve SpotBugs configurations of Gradle plugin
4. Exclude some errors which requires overhall of core application design
5. Exclude generated code which is located in
src/gen/corepath.Pull request type
Please mark github LABEL of the type of change your PR introduces:
Which ticket is resolved?
What does this PR change?
This PR is to make all SpotBugs error as build error.
The PR can be merged when All the fixes are merged because the CI build become failed.
Other information
Fixes
AlignPanelControllerto takeAligneras a method parameter #1299