Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reactor: Main class to adjust visivility of fields #1308

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

miurahr
Copy link
Member

@miurahr miurahr commented Mar 22, 2025

Pull request type

Please mark github LABEL of the type of change your PR introduces:

  • Other (describe below)
  • refactor

Which ticket is resolved?

What does this PR change?

  • Adjust for the following SpotBugs warnings.
M V MS_MUTABLE_COLLECTION_PKGPROTECT MS: org.omegat.Main.PARAMS is a mutable collection which should be package protected At Main.java:[line 136]	
M V MS_PKGPROTECT MS: org.omegat.Main.projectLocation should be package protected At Main.java:[line 130]	
M V MS_PKGPROTECT MS: org.omegat.Main.remoteProject should be package protected At Main.java:[line 133]	
M V MS_PKGPROTECT MS: org.omegat.Main.runMode should be package protected At Main.java:[line 139]	
M D NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE NP: Possible null pointer dereference in org.omegat.Main.restartGUI(String) due to return value of called method Dereferenced at Main.java:[line 267]	
M D REC_CATCH_EXCEPTION REC: Exception is caught when Exception is not thrown in org.omegat.Main.runGUI() At Main.java:[line 358]	

Other information

#1296

miurahr added 3 commits March 21, 2025 01:53
…ption types and removal of showError when GUI initialization failed.

Signed-off-by: Hiroshi Miura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants