Skip to content

Conversation

szakeetm
Copy link

@szakeetm szakeetm commented Sep 5, 2025

Description

Luftdaten firmware sends SCD30 sensor data as scd30_co2_ppm, which currently can't be matched to a sensor title.

Motivation and Context

With this addition, if you name a sensor phenomenon 'co2', 'carbon_dioxide', 'kohlendioxid', 'kohlenstoffdioxid' it will match against the sensor data sent by Luftdaten firmware.

How Has This Been Tested?

Luftdaten firmware provides debug info on the JSON sent. Example JSON measurement:

Data to send: {"software_version": "NRZ-2024-135", "sensordatavalues":
[{"value_type":"SCD30_temperature","value":"27.08"},{"value_type":"SCD30_humidity","value":"46.97"},
{"value_type":"SCD30_co2_ppm","value":"579.00"},{"value_type":"samples","value":"1089060"},
{"value_type":"min_micro","value":"25"},{"value_type":"max_micro","value":"93121"},
{"value_type":"interval","value":"30000"},{"value_type":"signal","value": [...]

Of which the {"value_type":"SCD30_co2_ppm","value":"579.00"} is the key. luftdatenHandler.js will split at the first underscore and try to match co2_ppm to a Phenomenon textbox value defined by the user.

Types of changes

luftdatenHandler.js matchings enum has two new entries for co2 and co2_ppm phenomenon and user-defined titles.

Checklist:

  • My code has been linted using yarn run lint.
  • My code does not break the tests (yarn run test)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@scheidtdav
Copy link
Collaborator

Hey @szakeetm,

thank very much for your contribution, we really appreciate it!
At the moment we are very busy with the next major version of openSenseMap and as such, things are changing in the background.

Due to that, your PR is unfortunately pointing to the wrong repository. This one will most likely be archived, as the next version of the api is living in the same repository as the frontend.

I saw that you have already opened this PR against the correct repository in sensebox/openSenseMap-API#950.
So please allow me to close this one.

We plan to release another version of the existing api soon. We will take your PR into account for that :-)

Thank you for your patience.

@scheidtdav scheidtdav closed this Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants