Skip to content

Conversation

@timber-they
Copy link
Contributor

Type of Change

  • Dependency upgrade
  • Bug fix (non-breaking change)
  • Breaking change
    • e.g. a fixed bug or new feature that may break something else
  • New feature
  • Code quality improvements
    • e.g. refactoring, documentation, tests, tooling, ...

Implementation

I implemented the /boxes/:senseBoxId/locations endpoint.

Checklist

  • I gave this pull request a meaningful title
  • My pull request is targeting the dev branch
  • I have added documentation to my code
  • I have deleted code that I have commented out

Additional Information

@timber-they timber-they self-assigned this Nov 9, 2025
@timber-they timber-they added the enhancement New feature or request label Nov 9, 2025
@timber-they timber-they linked an issue Nov 9, 2025 that may be closed by this pull request
Copy link
Collaborator

@scheidtdav scheidtdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the lint warnings, rest looks good!
Just waiting on the decision in #601

@timber-they
Copy link
Contributor Author

About the lint warnings, it's quite weird because I always run it locally and don't get those warnings... Maybe I need to reconfigure something

@scheidtdav
Copy link
Collaborator

About the lint warnings, it's quite weird because I always run it locally and don't get those warnings... Maybe I need to reconfigure something

Strange.. are you just running prettier or also running eslint?

Timber added 2 commits November 12, 2025 16:27
…openSenseMap/frontend into feat/migrate-boxes-senseBoxId-locations
@timber-they
Copy link
Contributor Author

About the lint warnings, it's quite weird because I always run it locally and don't get those warnings... Maybe I need to reconfigure something

Strange.. are you just running prettier or also running eslint?

Also eslint. But maybe I just miss the warnings because there's always so many of them for other files I didn't edit

@timber-they timber-they merged commit d201c47 into dev Nov 12, 2025
6 checks passed
@timber-they timber-they deleted the feat/migrate-boxes-senseBoxId-locations branch November 12, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

migrate /boxes/:senseBoxId/locations

3 participants