8360462: [macosx] row selection not working with Ctrl+Shift+Down/Up in AquaL&F

[prsadhuk]

Ctrl+Shift+Down/Up doesn't extend row selection down or up in Aqua L&F as it does in native tree view in Finder.
Fixed the keybindings.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8360462: [macosx] row selection not working with Ctrl+Shift+Down/Up in AquaL&F (Enhancement - P4)

Reviewers

• Abhishek Kumar (@kumarabhi006 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25966/head:pull/25966
$ git checkout pull/25966

Update a local copy of the PR:
$ git checkout pull/25966
$ git pull https://git.openjdk.org/jdk.git pull/25966/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25966

View PR using the GUI difftool:
$ git pr show -t 25966

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25966.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8360462: [macosx] row selection not working with Ctrl+Shift+Down/Up in AquaL&F

Reviewed-by: abhiscxk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

• 8ea544c: 8360287: JFR: PlatformTracer class should be loaded lazily
• 334683e: 8358645: Access violation in ThreadsSMRSupport::print_info_on during thread dump
• 20e0055: 8344165: Trace exceptions with a complete call-stack
• ... and 40 more: https://git.openjdk.org/jdk/compare/116b8543b04bfcf542af0ba03ac547a744600b7c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (11b61fac)
• 02: Full - Incremental (c6aa70bd)
• 01: Full - Incremental (4cd7677b)
• 00: Full (7e694599)

[DamonGuy]

I mentioned in your other PR that I can test this natively with a bunch of folders in Finder when viewing under List View. One note is that natively on macOS in Finder, there is a pinging noise for each CTRL+SHIFT+(UP/DOWN). This is in contrast to just SHIFT+(UP/DOWN) which does the same thing but without the pinging. Do you have any idea why this is?

Test looks good when testing myself.

[DamonGuy]

Suggested change

	* @summary Verifies ctrl+shift+down slects next row in AquaL&F
	* @summary Verifies ctrl+shift+down selects next row in Aqua L&F

[prsadhuk]

It seems to be "Alert" (Boop) sound (which can be changed in "Settings") being emanated..It probably will need to call macOS NSSound API if we have to replicate..I dont think we want to do this from Swing which is lightweight..

[kumarabhi006]

Verified the fix and look good to me. It aligns with the native side behaviour.