-
Notifications
You must be signed in to change notification settings - Fork 129
8348328: Update IANA Language Subtag Registry to Version 2025-05-15 #1846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back RadekCap! A progress list of the required criteria for merging this PR into |
@RadekCap This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 121 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Update IANA Language Subtag Registry to Version 2025-05-15 |
/approval request Update IANA Language Subtag Registry to Version 2025-05-15 |
HI @RadekCap |
Hi @GoeLin, Yes, I'm waiting for 24u approval. Let's see which will come sooner: the July update or 24u approval. |
I don't see anything going into 24u at this juncture. I can't see a closure message on the jdk-updates-dev mailing list, but apparently it entered RDP 2 as long ago as April 22nd, right after the last release. July's release will be the last update for 24u, before 25 is released in September. If we do want to get this into July ourselves, we should do so ASAP as the freeze is imminent (a week today for 17u & 21u, the Friday for 11u) Generally, I would say give the latest release two weeks and proceed with the LTS releases if nothing is approved in that time frame. |
Approval requests should really explain why this should be backported to the update, the expected risk and testing that has been done, so that the approver can make an informed decision. |
Updating the approval request to make the review easier. /approval request Update IANA Language Subtag Registry to Version 2025-05-15 Update to the latest IANA version. Clean backport. Passed tier1 tests. Passed gtests. |
Converting to draft as I'll use to add to the following CPU release. |
@GoeLin Hi, please review 21u PR if you have time, so we can include it in the following CPU release: Thank you. |
/approval request Update IANA Language Subtag Registry to Version 2025-05-15 Update to the latest IANA version. Clean backport. Passed tier1 tests. Passed gtests. |
@RadekCap |
/integrate |
/sponsor |
Going to push as commit 06ff0d6.
Your commit was automatically rebased without conflicts. |
@phohensee @RadekCap Pushed as commit 06ff0d6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of JDK-8348328 - Update IANA Language Subtag Registry to Version 2025-05-15
The IANA Functions Operator has updated the language subtag registry to "2025-05-15".
Clean backport.
Passed tier1 tests.
There are the same failures on the master branch in a local run:
GH Actions are passing, Windows failures are unrelated.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1846/head:pull/1846
$ git checkout pull/1846
Update a local copy of the PR:
$ git checkout pull/1846
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1846/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1846
View PR using the GUI difftool:
$ git pr show -t 1846
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1846.diff
Using Webrev
Link to Webrev Comment