Skip to content

8348328: Update IANA Language Subtag Registry to Version 2025-05-15 #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

RadekCap
Copy link
Contributor

@RadekCap RadekCap commented Jun 18, 2025

Backport of JDK-8348328 - Update IANA Language Subtag Registry to Version 2025-05-15

The IANA Functions Operator has updated the language subtag registry to "2025-05-15".

Clean backport.
Passed tier1 tests.

GH Actions are passing

A local run exposed the same subset of failing jtreg tier1 tests and on the master branch. Those failures are unrelated:

java/foreign/nested/TestNested.java:
PaddingLayout is a preview API and is disabled by default.

compiler/escapeAnalysis/TestFindInstMemRecursion.java:
test result: Failed. Execution failed: `main' threw exception: java.awt.AWTError: Can't connect to X11 window server using ':0' as the value of the DISPLAY variable.

// error, timeout
serviceability/sa/ClhsdbPstack.java#core
serviceability/sa/ClhsdbPstack.java#process
serviceability/sa/TestJhsdbJstackMixed.java

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8348328 needs maintainer approval

Issue

  • JDK-8348328: Update IANA Language Subtag Registry to Version 2025-05-15 (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/465/head:pull/465
$ git checkout pull/465

Update a local copy of the PR:
$ git checkout pull/465
$ git pull https://git.openjdk.org/jdk21u.git pull/465/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 465

View PR using the GUI difftool:
$ git pr show -t 465

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/465.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 18, 2025

👋 Welcome back RadekCap! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 18, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport f318868268f32934a2f0c4e26a6c75360d8e74b1 8348328: Update IANA Language Subtag Registry to Version 2025-05-15 Jun 18, 2025
@openjdk
Copy link

openjdk bot commented Jun 18, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 18, 2025
@openjdk
Copy link

openjdk bot commented Jun 18, 2025

⚠️ @RadekCap This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 18, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 18, 2025

Webrevs

@RadekCap
Copy link
Contributor Author

/approval request Update IANA Language Subtag Registry to Version 2025-05-15 Update to the latest IANA version. Clean backport. Passed tier1 tests.

@openjdk
Copy link

openjdk bot commented Jun 18, 2025

@RadekCap
8348328: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jun 18, 2025
@jerboaa
Copy link
Contributor

jerboaa commented Jun 23, 2025

@RadekCap Why is this being requested as a critical fix (to go into the July release)? If at all, it should perhaps go into the October release.

@RadekCap
Copy link
Contributor Author

@jerboaa It was my understanding from the original PR in 21u-dev - openjdk/jdk21u-dev#1846 (comment)

Based on this, I waited for 24u approval.

Based on the latest comment in 21u-dev - openjdk/jdk21u-dev#1846 (comment)

I created this PR in 21 to get it into the July release.

It's up to you, maintainers, if you would prefer a July or October release. I can do both.

I have a draft PRs in 21-udev, 17-udev, and 11-udev based on jdk approved change - openjdk/jdk#25503

Please let me know which way I should pick. Thank you.

@GoeLin
Copy link
Member

GoeLin commented Jun 23, 2025

Hi @RadekCap
I would just target the same release as Oracle does.
So we can just keep this pending until either Oracle pushes it to the July release
or the July release is delivered.
They will for sure backport it to the October update.
Best regards, Goetz.

@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Jun 27, 2025
@GoeLin
Copy link
Member

GoeLin commented Jul 11, 2025

Hi @RadekCap
I approved the change targeting jdk21u-dev. Please close this one.

@RadekCap
Copy link
Contributor Author

Closed as accepted in openjdk/jdk21u-dev#1846

@RadekCap RadekCap closed this Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants